From patchwork Fri Mar 22 16:56:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 1061397 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="M4F+qi7v"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44QqZH48LXz9sRf for ; Sat, 23 Mar 2019 03:56:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728623AbfCVQ4y (ORCPT ); Fri, 22 Mar 2019 12:56:54 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33588 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728572AbfCVQ4v (ORCPT ); Fri, 22 Mar 2019 12:56:51 -0400 Received: by mail-wr1-f66.google.com with SMTP id q1so3150355wrp.0 for ; Fri, 22 Mar 2019 09:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P7PijDAyYWVOUnASVOq5OlrtnenIzUv+8QkVaBxoLHo=; b=M4F+qi7vX2YkT2pog4N77K4kA3FNpWPZDj1vJEB10L5wRqdBP7YMN/wtCFu6TvlY1z aBSR9x7n0g+16wPOeHTlgk2je111/E2sirEoenUDhsjkHLgvPOnYSE0w11aOORdI+/BH Ah2wnkETwRA1LqXXs63EiHQtaPRfwp+A8X9/g2A2Tlih77azCSyhEAJJc3UdRGU5WeRo GRI5BFfv7k7Laj0m8W1iE9+mf/qEeudA1LN8U+uGdw7mD9aZ/ubjtXP8w6qLyKxWK6ik /uognuPCrxc5Pkfqr9Hiku/d60P49SdfkMt9nyCgxAXQmWzIMLGBKxvCPa6KabQ9Jilp C3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P7PijDAyYWVOUnASVOq5OlrtnenIzUv+8QkVaBxoLHo=; b=nDZsKgOA+hQAnHZ5tJYjBrTo9rokhHnNTts3yRyruL7/A4OibFZRwYBl1ZF6gmIN+2 GWWLt8jT1HsgfU5q51uUJyqE6I54tFmL0DEorysg2CKdqoQIsHWVloxUdYo3aSkvTWaW OzoYn6/NJRvcZDoi6ya6cgjM58hrPq3AknzbXLgFcYt0chcdnevAIVlhnR7Q7r8IYojM q8OmjHfeC5ZWM/nbJtjc6msNB4J1/IkuG5Ub9m1q0onyt7Np9t7gvudiqc6GwYoXsbz1 6u7NBrRoI+in6G8mv/ApEJofWbCEZ8XTXSzzsPWX7fe4LBRaZx6j0+ArfQP5Kq4dKoI8 y8ew== X-Gm-Message-State: APjAAAXWMbER7hJGl0ydd7O9sCae0VI+U84GXHqSyNABZsentvzTft61 2R9V8E5haBSw77QFDg1XQKwsXcztSGI= X-Google-Smtp-Source: APXvYqxKMsUqkT66uW9/mjcGttswP36Xa4VjRi3Kk0dQWoYITASrXClbtQ9wVG1D3G/Ax5H0Ad9aOQ== X-Received: by 2002:adf:d84d:: with SMTP id k13mr7936023wrl.154.1553273810053; Fri, 22 Mar 2019 09:56:50 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id e16sm19798521wrs.0.2019.03.22.09.56.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:56:49 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v2 07/15] net: devlink: don't pass return value of __devlink_port_type_set() Date: Fri, 22 Mar 2019 17:56:28 +0100 Message-Id: <20190322165636.1725-8-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190322165636.1725-1-jiri@resnulli.us> References: <20190322165636.1725-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko __devlink_port_type_set() returns void, it makes no sense to pass it on, so don't do that. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 1e125c3b890c..98ca788ffd97 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5379,8 +5379,7 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, void devlink_port_type_eth_set(struct devlink_port *devlink_port, struct net_device *netdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_ETH, netdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev); } EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); @@ -5393,8 +5392,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); void devlink_port_type_ib_set(struct devlink_port *devlink_port, struct ib_device *ibdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_IB, ibdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_IB, ibdev); } EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); @@ -5405,8 +5403,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); */ void devlink_port_type_clear(struct devlink_port *devlink_port) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_NOTSET, NULL); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_NOTSET, NULL); } EXPORT_SYMBOL_GPL(devlink_port_type_clear);