| Message ID | 20190127214800.4202-1-andrew@lunn.ch |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive | expand |
From: Andrew Lunn <andrew@lunn.ch> Date: Sun, 27 Jan 2019 22:48:00 +0100 > Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than > mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly > after the machine blows up. > > Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Applied, thanks Andrew.
Hello! On 28.01.2019 0:48, Andrew Lunn wrote: > Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than Due? > mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly > after the machine blows up. Never seen a stack overflow in the kernel... :-) > Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> MBR, Sergei
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c index 2caa8c8b4b55..1bfc5ff8d81d 100644 --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -664,7 +664,7 @@ int mv88e6390_serdes_irq_setup(struct mv88e6xxx_chip *chip, int port) if (port < 9) return 0; - return mv88e6390_serdes_irq_setup(chip, port); + return mv88e6390x_serdes_irq_setup(chip, port); } void mv88e6390x_serdes_irq_free(struct mv88e6xxx_chip *chip, int port)
Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly after the machine blows up. Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X") Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/serdes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)