| Message ID | 20190107175407.GA5612@ziepe.ca |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | phy: ti: Fix compilation failures without REGMAP | expand |
From: Jason Gunthorpe <jgg@mellanox.com> Date: Mon, 7 Jan 2019 17:54:14 +0000 > This driver requires regmap or the compile fails: > > drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’ > const struct reg_field (*regfields)[PHY_GMII_SEL_LAST]; > > Add it to kconfig. > > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Applied.
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig index f137e010776463..c4709ed7fb0e72 100644 --- a/drivers/phy/ti/Kconfig +++ b/drivers/phy/ti/Kconfig @@ -82,6 +82,7 @@ config PHY_TI_GMII_SEL default y if TI_CPSW=y depends on TI_CPSW || COMPILE_TEST select GENERIC_PHY + select REGMAP default m help This driver supports configuring of the TI CPSW Port mode depending on
This driver requires regmap or the compile fails: drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’ const struct reg_field (*regfields)[PHY_GMII_SEL_LAST]; Add it to kconfig. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> --- drivers/phy/ti/Kconfig | 1 + 1 file changed, 1 insertion(+) .. and this is why I'm even compiling this thing when I'm not doing anything with CPSW ..