diff mbox series

[iproute2,1/4] Makefile: have check target depend on all

Message ID 20181215153051.13166-1-bluca@debian.org
State Superseded, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2,1/4] Makefile: have check target depend on all | expand

Commit Message

Luca Boccassi Dec. 15, 2018, 3:30 p.m. UTC
Otherwise it will simply fail immediately from a just-cleaned
workspace:

$ make check -j1
cd testsuite && make && make alltests
echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
Entering iproute2
make -C tools
Makefile:3: ../../config.mk: No such file or directory
make[2]: *** No rule to make target '../../config.mk'.  Stop.

Fixes: 8804a8c0d387 ("Makefile: Add check target")
Cc: petr.vorel@gmail.com

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel Dec. 15, 2018, 4:13 p.m. UTC | #1
Hi Luca,

> Otherwise it will simply fail immediately from a just-cleaned
> workspace:

> $ make check -j1
> cd testsuite && make && make alltests
> echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
> Entering iproute2
> make -C tools
> Makefile:3: ../../config.mk: No such file or directory
> make[2]: *** No rule to make target '../../config.mk'.  Stop.

> Fixes: 8804a8c0d387 ("Makefile: Add check target")
> Cc: petr.vorel@gmail.com

> Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for a fix. I added 92885e19 ("testsuite: Fix make check when need build
generate_nlmsg"), but that wasn't enough.


Kind regards,
Petr
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index b7488add..20c760e2 100644
--- a/Makefile
+++ b/Makefile
@@ -119,7 +119,7 @@  clobber:
 
 distclean: clobber
 
-check:
+check: all
 	cd testsuite && $(MAKE) && $(MAKE) alltests
 
 cscope: