diff mbox series

[iproute2] iproute2: Installation errors without libnml

Message ID 20181203101814.4713-1-emeric.dupont@zii.aero
State Superseded, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2] iproute2: Installation errors without libnml | expand

Commit Message

Émeric Dupont Dec. 3, 2018, 10:18 a.m. UTC
When performing make install in iproute2 (current git master),
     if $(HAVE_MNL) is not selected, some Makefiles try to call
     install with an empty target, which causes a non-critical make error.

Signed-off-by: Emeric Dupont <emeric.dupont@zii.aero>
---
 devlink/Makefile | 4 +++-
 rdma/Makefile    | 4 +++-
 tipc/Makefile    | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

Comments

Michal Kubecek Dec. 3, 2018, 10:37 a.m. UTC | #1
On Mon, Dec 03, 2018 at 11:18:14AM +0100, Emeric Dupont wrote:
> When performing make install in iproute2 (current git master),
>      if $(HAVE_MNL) is not selected, some Makefiles try to call
>      install with an empty target, which causes a non-critical make error.
> 
> Signed-off-by: Emeric Dupont <emeric.dupont@zii.aero>
> ---

You have a typo in patch subject (should be "libmnl").

Michal Kubecek
diff mbox series

Patch

diff --git a/devlink/Makefile b/devlink/Makefile
index ace34c7b..9cc4888d 100644
--- a/devlink/Makefile
+++ b/devlink/Makefile
@@ -19,7 +19,9 @@  devlink: $(DEVLINKOBJ)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(DEVLINKOBJ) $(TARGETS)
diff --git a/rdma/Makefile b/rdma/Makefile
index 819fcbe3..0498994f 100644
--- a/rdma/Makefile
+++ b/rdma/Makefile
@@ -17,7 +17,9 @@  rdma:	$(RDMA_OBJ) $(LIBS)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(RDMA_OBJ) $(TARGETS)
diff --git a/tipc/Makefile b/tipc/Makefile
index fdb18d39..a10debe0 100644
--- a/tipc/Makefile
+++ b/tipc/Makefile
@@ -22,7 +22,9 @@  tipc: $(TIPCOBJ)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(TIPCOBJ) $(TARGETS)