| Message ID | 20181202195630.2129-1-emeric.dupont@zii.aero |
|---|---|
| State | Superseded, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] iproute2: Installation errors without libnml | expand |
Hi Émeric, On December 2, 2018 11:57:00 AM PST, "Émeric Dupont" <emeric.dupont@zii.aero> wrote: >When performing make install in iproute2 (current git master), > if $(HAVE_MNL) is not selected, some Makefiles try to call > install with an empty target, which causes a non-critical make error. You need to add a Signed-off-by tag here as per the iproute2/Linux certificate of origin. [Snip] > >This email and any files transmitted with it are confidential & >proprietary to Zodiac Inflight Innovations. This information is >intended solely for the use of the individual or entity to which it is >addressed. Access or transmittal of the information contained in this >e-mail, in full or in part, to any other organization or persons is not >authorized. This is incompatible with you sending patches for open source software, can you work with your IT to either remove that footer by BCC/CC'ing a specific email address or use a personal email just to get the patch out?
diff --git a/devlink/Makefile b/devlink/Makefile index ace34c7b..9cc4888d 100644 --- a/devlink/Makefile +++ b/devlink/Makefile @@ -19,7 +19,9 @@ devlink: $(DEVLINKOBJ) $(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@ install: all -install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR) +for i in $(TARGETS); \ +do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \ +done clean: rm -f $(DEVLINKOBJ) $(TARGETS) diff --git a/rdma/Makefile b/rdma/Makefile index 819fcbe3..0498994f 100644 --- a/rdma/Makefile +++ b/rdma/Makefile @@ -17,7 +17,9 @@ rdma:$(RDMA_OBJ) $(LIBS) $(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@ install: all -install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR) +for i in $(TARGETS); \ +do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \ +done clean: rm -f $(RDMA_OBJ) $(TARGETS) diff --git a/tipc/Makefile b/tipc/Makefile index fdb18d39..a10debe0 100644 --- a/tipc/Makefile +++ b/tipc/Makefile @@ -22,7 +22,9 @@ tipc: $(TIPCOBJ) $(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@ install: all -install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR) +for i in $(TARGETS); \ +do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \ +done clean: rm -f $(TIPCOBJ) $(TARGETS)
When performing make install in iproute2 (current git master), if $(HAVE_MNL) is not selected, some Makefiles try to call install with an empty target, which causes a non-critical make error. --- devlink/Makefile | 4 +++- rdma/Makefile | 4 +++- tipc/Makefile | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) -- 2.19.2 TriaGnoSys GmbH, Registergericht: München HRB 141647, Vat.: DE 813396184 Geschäftsführer: Núria Riera Díaz, Peter Lewalter