| Message ID | 20181119230335.11771-2-jakub.kicinski@netronome.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Ahern |
| Headers | show |
| Series | tc: gred: JSON-ify and support per-vq config | expand |
diff --git a/tc/q_gred.c b/tc/q_gred.c index e63fac72a883..80a9ccbbd3cb 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -302,8 +302,6 @@ static int gred_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) return -1; } -/* Bad hack! should really return a proper message as shown above*/ - fprintf(f, "vqs %u default %u %s", sopt->DPs, sopt->def_DP,
The comment about providing a proper message seems similar to the comment in the kernel which says: /* hack -- fix at some point with proper message This is how we indicate to tc that there is no VQ at this DP */ it's unclear what that message would be, and whether it's needed. Remove the confusing comment. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> --- tc/q_gred.c | 2 -- 1 file changed, 2 deletions(-)