From patchwork Thu Nov 15 22:36:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 998588 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="KeZdH6R5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42wx7X13K6z9s9G for ; Fri, 16 Nov 2018 09:37:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389072AbeKPIqr (ORCPT ); Fri, 16 Nov 2018 03:46:47 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37200 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389076AbeKPIqr (ORCPT ); Fri, 16 Nov 2018 03:46:47 -0500 Received: by mail-pf1-f196.google.com with SMTP id u3-v6so7697707pfm.4 for ; Thu, 15 Nov 2018 14:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PAkHdZKfcljdSMGMUlYM8LlDmcSBflHDS5gNm7JdPUQ=; b=KeZdH6R5YzkYGiUxfraaOzUPTOybePA6QqCf4jwSWd/UFu5RiiyTRJkODrk+/0eVb/ fiO40aw+Kct917VNviHH8ynka+HFXFDWWWV1UzzhDshryTcPKrHb89xkIfQOWHNQKv1g 1mDiPBXlSOvSXyfyKZvwLKXmBoNjHtrMXV3U0prOXpLW1uEvaNW6XfauiS+Yh6iOIDRo +9Y1xcPN7twMN0QBcTGxfXjfTqgSleN9zI13uKpOtVwyTerL3xiaJjdvuBP82JWrBZn6 E+gSd5gGyncOmyWm2uRPwACr+ETkv3wvxuZF/x3SmjF6dbGoC0VTyRYjW911SCSSXMoK jkBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PAkHdZKfcljdSMGMUlYM8LlDmcSBflHDS5gNm7JdPUQ=; b=G/UWFyD3wp3Rdp+yVl36cWyTPqxAUj1guqWytyxgfi+en7c2exZxmCVCNq/EEA5q7W kLnw/bzA+YvpXFd3jFDw2gowVTrl1x/fNNSD0CgexGMlLgjHtBnRJdL5/9ARnWt0Podu jQRcX3+2TdYoFBofWOZCJPmCwCHj+fUdTnFWDUh0kEwARbs90ZkVZFrQai+KDFYFOKwG zw9+DrzFxQG+BWlTBi6ByrR28sY+ppS61ju1agU8lwo80T+/wtF5C5ZXGVmjqgjBFx5P Z4ziURVwBMRS8ijyTgdoVATnBOIJYtlehCBpaVrAZw2U6PPN69viGSUN2q7ZqHGRSypY KUYA== X-Gm-Message-State: AGRZ1gL4irQ7XT4zKNn+h8AgwFJRY/5oNkb4AXsUQoqqrIBy23Z6u0Hj aneEJ6NOAsjy4ZUgurjmlPreZ6X/nCEaag== X-Google-Smtp-Source: AJdET5fTHwOOx/QFaPWgS6VhjLgNUm9r/FkN8DkvZwuz7zJfYsA9bIp7r02lVVIOT8/Ppe6Gp//Gug== X-Received: by 2002:a62:3948:: with SMTP id g69mr8517561pfa.114.1542321423060; Thu, 15 Nov 2018 14:37:03 -0800 (PST) Received: from localhost.localdomain ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id c23-v6sm30580084pfn.95.2018.11.15.14.37.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 14:37:02 -0800 (PST) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [PATCH iproute2 21/22] tc/pedit: use structure initialization Date: Thu, 15 Nov 2018 14:36:39 -0800 Message-Id: <20181115223640.411-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181115223640.411-1-stephen@networkplumber.org> References: <20181115223640.411-1-stephen@networkplumber.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pedit callback structure table should be iniatialized using structure initialization to avoid structure changes problems. Signed-off-by: Stephen Hemminger --- tc/p_eth.c | 5 ++--- tc/p_icmp.c | 5 ++--- tc/p_ip.c | 5 ++--- tc/p_ip6.c | 5 ++--- tc/p_tcp.c | 5 ++--- tc/p_udp.c | 5 ++--- 6 files changed, 12 insertions(+), 18 deletions(-) diff --git a/tc/p_eth.c b/tc/p_eth.c index 53ce736a1d78..674f9c11202a 100644 --- a/tc/p_eth.c +++ b/tc/p_eth.c @@ -68,7 +68,6 @@ done: } struct m_pedit_util p_pedit_eth = { - NULL, - "eth", - parse_eth, + .id = "eth", + .parse_peopt = parse_eth, }; diff --git a/tc/p_icmp.c b/tc/p_icmp.c index 2c1baf82f7ad..15ce32309e39 100644 --- a/tc/p_icmp.c +++ b/tc/p_icmp.c @@ -55,7 +55,6 @@ done: } struct m_pedit_util p_pedit_icmp = { - NULL, - "icmp", - parse_icmp, + .id = "icmp", + .parse_peopt = parse_icmp, }; diff --git a/tc/p_ip.c b/tc/p_ip.c index e9fd6f834efc..c385ac6dbcaa 100644 --- a/tc/p_ip.c +++ b/tc/p_ip.c @@ -156,7 +156,6 @@ done: } struct m_pedit_util p_pedit_ip = { - NULL, - "ip", - parse_ip, + .id = "ip", + .parse_peopt = parse_ip, }; diff --git a/tc/p_ip6.c b/tc/p_ip6.c index bc45ab70d319..dbfdca42cce7 100644 --- a/tc/p_ip6.c +++ b/tc/p_ip6.c @@ -84,7 +84,6 @@ done: } struct m_pedit_util p_pedit_ip6 = { - NULL, - "ipv6", - parse_ip6, + .id = "ipv6", + .parse_peopt = parse_ip6, }; diff --git a/tc/p_tcp.c b/tc/p_tcp.c index eeb68fcf87b3..d2dbfd719526 100644 --- a/tc/p_tcp.c +++ b/tc/p_tcp.c @@ -67,7 +67,6 @@ done: return res; } struct m_pedit_util p_pedit_tcp = { - NULL, - "tcp", - parse_tcp, + .id = "tcp", + .parse_peopt = parse_tcp, }; diff --git a/tc/p_udp.c b/tc/p_udp.c index 68c688efd110..bab456de9831 100644 --- a/tc/p_udp.c +++ b/tc/p_udp.c @@ -61,7 +61,6 @@ done: } struct m_pedit_util p_pedit_udp = { - NULL, - "udp", - parse_udp, + .id = "udp", + .parse_peopt = parse_udp, };