| Message ID | 20181102105741.25381-1-bluca@debian.org |
|---|---|
| State | Superseded, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] Fix warning in tc-skbprio.8 manpage | expand |
On 02/11/18 10:57, Luca Boccassi wrote: > ". If" gets interpreted as a macro, so move the period to the previous > line: > > 33: warning: macro `If' not defined > > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") > > Signed-off-by: Luca Boccassi <bluca@debian.org> > --- > man/man8/tc-skbprio.8 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8 > index 844bbf46..8b259839 100644 > --- a/man/man8/tc-skbprio.8 > +++ b/man/man8/tc-skbprio.8 > @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how > .B skb->priority > is assigned. A typical use case is to copy > the 6-bit DS field of IPv4 and IPv6 packets using > -.BR tc-skbedit (8) > -. If > +.BR tc-skbedit (8) . > +If Won't that make the full-stop bold? Removing the space, i.e. .BR rc-skbedit (8). ought to work. -Ed > .B skb->priority > is greater or equal to 64, the priority is assumed to be 63. > Priorities less than 64 are taken at face value.
On Fri, 2018-11-02 at 15:19 +0000, Edward Cree wrote: > On 02/11/18 10:57, Luca Boccassi wrote: > > ". If" gets interpreted as a macro, so move the period to the > > previous > > line: > > > > 33: warning: macro `If' not defined > > > > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") > > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > --- > > man/man8/tc-skbprio.8 | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8 > > index 844bbf46..8b259839 100644 > > --- a/man/man8/tc-skbprio.8 > > +++ b/man/man8/tc-skbprio.8 > > @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how > > .B skb->priority > > is assigned. A typical use case is to copy > > the 6-bit DS field of IPv4 and IPv6 packets using > > -.BR tc-skbedit (8) > > -. If > > +.BR tc-skbedit (8) . > > +If > > Won't that make the full-stop bold? > Removing the space, i.e. > .BR rc-skbedit (8). > ought to work. > -Ed Yes you are right, fixed in v2, thanks.
On Fri, 2 Nov 2018 10:57:41 +0000 Luca Boccassi <bluca@debian.org> wrote: > ". If" gets interpreted as a macro, so move the period to the previous > line: > > 33: warning: macro `If' not defined > > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") > > Signed-off-by: Luca Boccassi <bluca@debian.org> Applied
diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8 index 844bbf46..8b259839 100644 --- a/man/man8/tc-skbprio.8 +++ b/man/man8/tc-skbprio.8 @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how .B skb->priority is assigned. A typical use case is to copy the 6-bit DS field of IPv4 and IPv6 packets using -.BR tc-skbedit (8) -. If +.BR tc-skbedit (8) . +If .B skb->priority is greater or equal to 64, the priority is assumed to be 63. Priorities less than 64 are taken at face value.
". If" gets interpreted as a macro, so move the period to the previous line: 33: warning: macro `If' not defined Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") Signed-off-by: Luca Boccassi <bluca@debian.org> --- man/man8/tc-skbprio.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)