| Message ID | 20181029215648.3043831-1-yhs@fb.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf] tools/bpf: add unlimited rlimit for flow_dissector_load | expand |
On Mon, Oct 29, 2018 at 2:58 PM Yonghong Song <yhs@fb.com> wrote: > > On our test machine, bpf selftest test_flow_dissector.sh failed > with the following error: > # ./test_flow_dissector.sh > bpffs not mounted. Mounting... > libbpf: failed to create map (name: 'jmp_table'): Operation not permitted > libbpf: failed to load object 'bpf_flow.o' > ./flow_dissector_load: bpf_prog_load bpf_flow.o > selftests: test_flow_dissector [FAILED] > > Let us increase the rlimit to remove the above map > creation failure. > > Signed-off-by: Yonghong Song <yhs@fb.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > tools/testing/selftests/bpf/flow_dissector_load.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c > index d3273b5b3173..ae8180b11d5f 100644 > --- a/tools/testing/selftests/bpf/flow_dissector_load.c > +++ b/tools/testing/selftests/bpf/flow_dissector_load.c > @@ -11,6 +11,8 @@ > #include <bpf/bpf.h> > #include <bpf/libbpf.h> > > +#include "bpf_rlimit.h" > + > const char *cfg_pin_path = "/sys/fs/bpf/flow_dissector"; > const char *cfg_map_name = "jmp_table"; > bool cfg_attach = true; > -- > 2.17.1 >
On 10/29/2018 10:56 PM, Yonghong Song wrote: > On our test machine, bpf selftest test_flow_dissector.sh failed > with the following error: > # ./test_flow_dissector.sh > bpffs not mounted. Mounting... > libbpf: failed to create map (name: 'jmp_table'): Operation not permitted > libbpf: failed to load object 'bpf_flow.o' > ./flow_dissector_load: bpf_prog_load bpf_flow.o > selftests: test_flow_dissector [FAILED] > > Let us increase the rlimit to remove the above map > creation failure. > > Signed-off-by: Yonghong Song <yhs@fb.com> Applied to bpf, thanks!
diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c index d3273b5b3173..ae8180b11d5f 100644 --- a/tools/testing/selftests/bpf/flow_dissector_load.c +++ b/tools/testing/selftests/bpf/flow_dissector_load.c @@ -11,6 +11,8 @@ #include <bpf/bpf.h> #include <bpf/libbpf.h> +#include "bpf_rlimit.h" + const char *cfg_pin_path = "/sys/fs/bpf/flow_dissector"; const char *cfg_map_name = "jmp_table"; bool cfg_attach = true;
On our test machine, bpf selftest test_flow_dissector.sh failed with the following error: # ./test_flow_dissector.sh bpffs not mounted. Mounting... libbpf: failed to create map (name: 'jmp_table'): Operation not permitted libbpf: failed to load object 'bpf_flow.o' ./flow_dissector_load: bpf_prog_load bpf_flow.o selftests: test_flow_dissector [FAILED] Let us increase the rlimit to remove the above map creation failure. Signed-off-by: Yonghong Song <yhs@fb.com> --- tools/testing/selftests/bpf/flow_dissector_load.c | 2 ++ 1 file changed, 2 insertions(+)