| Message ID | 20181011150621.8466-1-bigeasy@linutronix.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: sfp: remove sfp_mutex's definition | expand |
On Thu, Oct 11, 2018 at 05:06:21PM +0200, Sebastian Andrzej Siewior wrote: > The sfp_mutex variable is defined but never used in this file. Not even > in the commit that introduced that variable. > > Remove sfp_mutex, it has no purpose. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Thu, 11 Oct 2018 17:06:21 +0200 > The sfp_mutex variable is defined but never used in this file. Not even > in the commit that introduced that variable. > > Remove sfp_mutex, it has no purpose. > > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: "David S. Miller" <davem@davemloft.net> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Applied.
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 6e13b8832bc7d..fd8bb998ae52d 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -163,8 +163,6 @@ static const enum gpiod_flags gpio_flags[] = { /* Give this long for the PHY to reset. */ #define T_PHY_RESET_MS 50 -static DEFINE_MUTEX(sfp_mutex); - struct sff_data { unsigned int gpios; bool (*module_supported)(const struct sfp_eeprom_id *id);
The sfp_mutex variable is defined but never used in this file. Not even in the commit that introduced that variable. Remove sfp_mutex, it has no purpose. Cc: Andrew Lunn <andrew@lunn.ch> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/net/phy/sfp.c | 2 -- 1 file changed, 2 deletions(-)