Message ID | 20180725223927.4466-1-jakub.kicinski@netronome.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | [net] netdevsim: don't leak devlink resources | expand |
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Wed, 25 Jul 2018 15:39:27 -0700 > Devlink resources registered with devlink_resource_register() have > to be unregistered. > > Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via devlink") > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Applied and queued up for -stable.
diff --git a/drivers/net/netdevsim/devlink.c b/drivers/net/netdevsim/devlink.c index ba663e5af168..5135fc371f01 100644 --- a/drivers/net/netdevsim/devlink.c +++ b/drivers/net/netdevsim/devlink.c @@ -207,6 +207,7 @@ void nsim_devlink_teardown(struct netdevsim *ns) struct net *net = nsim_to_net(ns); bool *reg_devlink = net_generic(net, nsim_devlink_id); + devlink_resources_unregister(ns->devlink, NULL); devlink_unregister(ns->devlink); devlink_free(ns->devlink); ns->devlink = NULL;