| Message ID | 20180512170925.23690-1-christophe.jaillet@wanadoo.fr |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()' | expand |
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Date: Sat, 12 May 2018 19:09:25 +0200 > 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Saeed, I assume I will see this in one of your forthcoming pull requests. Thanks.
Le 14/05/2018 à 20:56, David Miller a écrit : > From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Date: Sat, 12 May 2018 19:09:25 +0200 > >> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Saeed, I assume I will see this in one of your forthcoming pull > requests. > > Thanks. > I've send a v2 with additional 'kvfree()' fixes. CJ
On Mon, May 14, 2018 at 11:56 AM, David Miller <davem@davemloft.net> wrote: > From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Date: Sat, 12 May 2018 19:09:25 +0200 > >> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Saeed, I assume I will see this in one of your forthcoming pull > requests. > > Thanks. In case this is for net-next, I will apply v3 to mlx5-next once Christophe adds the "Fixes" tags according to Eric's request. if it is for net (RC) then you can go ahead and apply v3 to net branch. Thanks, Saeed.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c index 177e076b8d17..49968a4db758 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c @@ -511,7 +511,7 @@ int mlx5_query_nic_vport_system_image_guid(struct mlx5_core_dev *mdev, *system_image_guid = MLX5_GET64(query_nic_vport_context_out, out, nic_vport_context.system_image_guid); - kfree(out); + kvfree(out); return 0; }
'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/mellanox/mlx5/core/vport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)