| Message ID | 20180424221952.12081-1-anders.roxell@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED | expand |
From: Anders Roxell <anders.roxell@linaro.org> Date: Wed, 25 Apr 2018 00:19:52 +0200 > Script in_netns.sh is a utility function and not its own test so it > shouldn't be part of the TEST_PROGS. The in_netns.sh get used by > run_afpackettests. > To install in_netns.sh without being added to the main run_kselftest.sh > script use the TEST_GEN_PROGS_EXTENDED variable. > > Fixes: 5ff9c1a3dd92 ("selftests: net: add in_netns.sh to TEST_PROGS") > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Please respin this against the 'net' tree as we want this bug fixed there not just 'net-next'. Thanks.
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index c3761c35f542..4a8cfe8071a7 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -5,7 +5,8 @@ CFLAGS = -Wall -Wl,--no-as-needed -O2 -g CFLAGS += -I../../../../usr/include/ TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh rtnetlink.sh -TEST_PROGS += fib_tests.sh fib-onlink-tests.sh in_netns.sh pmtu.sh +TEST_PROGS += fib_tests.sh fib-onlink-tests.sh pmtu.sh +TEST_GEN_PROGS_EXTENDED := in_netns.sh TEST_GEN_FILES = socket TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy TEST_GEN_FILES += tcp_mmap
Script in_netns.sh is a utility function and not its own test so it shouldn't be part of the TEST_PROGS. The in_netns.sh get used by run_afpackettests. To install in_netns.sh without being added to the main run_kselftest.sh script use the TEST_GEN_PROGS_EXTENDED variable. Fixes: 5ff9c1a3dd92 ("selftests: net: add in_netns.sh to TEST_PROGS") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- tools/testing/selftests/net/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)