| Message ID | 20180409124336.29274-1-colin.king@canonical.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/mlx5: remove some extraneous spaces in indentations | expand |
On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are several lines where there is an extraneous space causing > indentation misalignment. Remove them. > > Cleans up Cocconelle warnings: > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned > with following code on line 410 > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned > with following code on line 416 > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned > with following code on line 422 > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) applied to for-next thanks Jason
On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote: > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > There are several lines where there is an extraneous space causing > > indentation misalignment. Remove them. > > > > Cleans up Cocconelle warnings: > > > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned > > with following code on line 410 > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned > > with following code on line 416 > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned > > with following code on line 422 > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > applied to for-next thanks Oh wait, this is for netdev, not rdma sorry. Never mind, DaveM should pick it up. Jason
On Tue, 2018-04-10 at 17:27 -0600, Jason Gunthorpe wrote: > On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote: > > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > > > There are several lines where there is an extraneous space > > > causing > > > indentation misalignment. Remove them. > > > > > > Cleans up Cocconelle warnings: > > > > > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code > > > aligned > > > with following code on line 410 > > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code > > > aligned > > > with following code on line 416 > > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code > > > aligned > > > with following code on line 422 > > > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++----- > > > ---- > > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > applied to for-next thanks > > Oh wait, this is for netdev, not rdma sorry. Never mind, DaveM should > pick it up. > net-next is currently closed. Dave, if it is ok with you I would like to apply this into mlx5-next branch so it won't cause any issues with our next pull requests to rdma and netdev. > Jason
From: Saeed Mahameed <saeedm@mellanox.com> Date: Wed, 11 Apr 2018 18:23:41 +0000 > Dave, if it is ok with you I would like to apply this into mlx5-next > branch so it won't cause any issues with our next pull requests to rdma > and netdev. Ok.
On Mon, 2018-04-09 at 13:43 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are several lines where there is an extraneous space causing > indentation misalignment. Remove them. > > Cleans up Cocconelle warnings: > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned > with following code on line 410 > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned > with following code on line 416 > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned > with following code on line 422 > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Applied to mlx5-next, Thanks Colin!
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/qp.c b/drivers/net/ethernet/mellanox/mlx5/core/qp.c index 02d6c5b5d502..4ca07bfb6b14 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/qp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/qp.c @@ -407,21 +407,21 @@ static int modify_qp_mbox_alloc(struct mlx5_core_dev *dev, u16 opcode, int qpn, case MLX5_CMD_OP_RST2INIT_QP: if (MBOX_ALLOC(mbox, rst2init_qp)) return -ENOMEM; - MOD_QP_IN_SET_QPC(rst2init_qp, mbox->in, opcode, qpn, - opt_param_mask, qpc); - break; + MOD_QP_IN_SET_QPC(rst2init_qp, mbox->in, opcode, qpn, + opt_param_mask, qpc); + break; case MLX5_CMD_OP_INIT2RTR_QP: if (MBOX_ALLOC(mbox, init2rtr_qp)) return -ENOMEM; - MOD_QP_IN_SET_QPC(init2rtr_qp, mbox->in, opcode, qpn, - opt_param_mask, qpc); - break; + MOD_QP_IN_SET_QPC(init2rtr_qp, mbox->in, opcode, qpn, + opt_param_mask, qpc); + break; case MLX5_CMD_OP_RTR2RTS_QP: if (MBOX_ALLOC(mbox, rtr2rts_qp)) return -ENOMEM; - MOD_QP_IN_SET_QPC(rtr2rts_qp, mbox->in, opcode, qpn, - opt_param_mask, qpc); - break; + MOD_QP_IN_SET_QPC(rtr2rts_qp, mbox->in, opcode, qpn, + opt_param_mask, qpc); + break; case MLX5_CMD_OP_RTS2RTS_QP: if (MBOX_ALLOC(mbox, rts2rts_qp)) return -ENOMEM;