From patchwork Thu Mar 22 10:55:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 889313 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="ur7H77qq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 406Nrh4BNFz9s1X for ; Thu, 22 Mar 2018 21:56:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbeCVK4S (ORCPT ); Thu, 22 Mar 2018 06:56:18 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:37482 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526AbeCVKz2 (ORCPT ); Thu, 22 Mar 2018 06:55:28 -0400 Received: by mail-wr0-f193.google.com with SMTP id z12so8210680wrg.4 for ; Thu, 22 Mar 2018 03:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=I1FEa67XNy4i3pzkd3HByo4wDiPbkQYlph2NLPuTIFo=; b=ur7H77qqGPG5ins+osPMtIUYzTtOiKQXIl/aQLICgFQ0/GEbIpAxDCdZEbD++4to4J Q9E7uLYXQ0MTlvaij6FC4vWSOBl7KfWW9nQYuX8ew06ecIuQib3WNcIDgbXV+kOrMszS IKWFsqE+VVJwYG883wKV4eMBeXMv01XyMQkyxhQJOy6gCA2x68y30iPdsVkP/1mnMX1w jIMYIAeGhF+YZTkh+4O+oZpq4e2xR8/DGyt8paMUW7dsnf0k8vaVk/4UGDYreiW5lckd sTqhsEA7LaiEWj9OFqlocQpRTJYfWb29a1L+c8al1T4eda0UOr5IymcMEhYMa7v9cWGu tmig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=I1FEa67XNy4i3pzkd3HByo4wDiPbkQYlph2NLPuTIFo=; b=Vl4owKqKWoSM6QDHgsHbdH/Sl2mfToAEag4eFiaIdTuWbc8wa2s4La9NwdBNmOaZwr Lg7LaX8sAiKXxClb8GDDe8N+aeKv/ojUL68iScKxbmyb0arHh5d/ELGmBnrRhnkXygV4 moP+yqqfNB3PM+t6HkgByh6U7IOsPwe7NpuNqYo+eHsJypgoi0HleZipvt0gN/hdsTsw PQdwyCws1JU35fAKAqnqxU6JZ0HQQtmPdSYSvz8bmF2GYs+4BDb0gA+sDPJVffs5u81x UB7bMwt1eV1X8KEkY2+6lu13BVfxUG1rLAZKYcy2NYQ2a1wr15gbdcp9UDGpX4hAWH6L /hAw== X-Gm-Message-State: AElRT7GENWkIXQPVNjuh0yFSUYhnN7r4B15v/p3wNdNhnkT4TYk8zQa5 YE4PdAjekjQ8WEvt+/T+/9NYu0XN X-Google-Smtp-Source: AG47ELs7ouram6DyBYoxivtLuCCRNBcNmEwMDAwfBo9ERLbRA+FGL6hxL4tdqpsR7gI0NtuVdfpO8Q== X-Received: by 10.223.161.145 with SMTP id u17mr14788692wru.61.1521716127388; Thu, 22 Mar 2018 03:55:27 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id y15sm4062992wrh.39.2018.03.22.03.55.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 03:55:27 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, jakub.kicinski@netronome.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com, satananda.burla@cavium.com, raghu.vatsavayi@cavium.com, felix.manlunas@cavium.com, gospo@broadcom.com, sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com, tariqt@mellanox.com, eranbe@mellanox.com, jeffrey.t.kirsher@intel.com Subject: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports Date: Thu, 22 Mar 2018 11:55:14 +0100 Message-Id: <20180322105522.8186-5-jiri@resnulli.us> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180322105522.8186-1-jiri@resnulli.us> References: <20180322105522.8186-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Set the attrs and allow to expose port flavour to user via devlink. Signed-off-by: Jiri Pirko --- net/dsa/dsa2.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index adf50fbc4c13..49453690696d 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -270,7 +270,27 @@ static int dsa_port_setup(struct dsa_port *dp) case DSA_PORT_TYPE_UNUSED: break; case DSA_PORT_TYPE_CPU: + /* dp->index is used now as port_number. However + * CPU ports should have separate numbering + * independent from front panel port numbers. + */ + devlink_port_attrs_set(&dp->devlink_port, + DEVLINK_PORT_FLAVOUR_CPU, + dp->index, false, 0); + err = dsa_port_link_register_of(dp); + if (err) { + dev_err(ds->dev, "failed to setup link for port %d.%d\n", + ds->index, dp->index); + return err; + } case DSA_PORT_TYPE_DSA: + /* dp->index is used now as port_number. However + * DSA ports should have separate numbering + * independent from front panel port numbers. + */ + devlink_port_attrs_set(&dp->devlink_port, + DEVLINK_PORT_FLAVOUR_DSA, + dp->index, false, 0); err = dsa_port_link_register_of(dp); if (err) { dev_err(ds->dev, "failed to setup link for port %d.%d\n", @@ -279,6 +299,9 @@ static int dsa_port_setup(struct dsa_port *dp) } break; case DSA_PORT_TYPE_USER: + devlink_port_attrs_set(&dp->devlink_port, + DEVLINK_PORT_FLAVOUR_PHYSICAL, + dp->index, false, 0); err = dsa_slave_create(dp); if (err) dev_err(ds->dev, "failed to create slave for port %d.%d\n",