diff mbox series

[iproute2-next] ip: don't colorize the master device

Message ID 20180220190846.17356-1-stephen@networkplumber.org
State Accepted, archived
Delegated to: David Ahern
Headers show
Series [iproute2-next] ip: don't colorize the master device | expand

Commit Message

Stephen Hemminger Feb. 20, 2018, 7:08 p.m. UTC 
From: Stephen Hemminger <sthemmin@microsoft.com>

Putting whole string "master eth0" in the interface name color
is wrong and confusing. Let's just turn color off for all attributes
of device.

Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 ip/ipaddress.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

David Ahern Feb. 20, 2018, 8:18 p.m. UTC | #1 
On 2/20/18 12:08 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> Putting whole string "master eth0" in the interface name color
> is wrong and confusing. Let's just turn color off for all attributes
> of device.
> 
> Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  ip/ipaddress.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Change in behavior too. Applied to iproute2-next
diff mbox series

Patch

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 1380453984d5..768e2ed27e76 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -888,11 +888,9 @@  int print_linkinfo(const struct sockaddr_nl *who,
 	if (tb[IFLA_MASTER]) {
 		int master = rta_getattr_u32(tb[IFLA_MASTER]);
 
-		print_color_string(PRINT_ANY,
-				   COLOR_IFNAME,
-				   "master",
-				   "master %s ",
-				   ll_index_to_name(master));
+		print_string(PRINT_ANY,
+			     "master", "master %s ",
+			     ll_index_to_name(master));
 	}
 
 	if (tb[IFLA_OPERSTATE])