diff mbox series

[net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg

Message ID 20171027213703.GA1107@felix-thinkpad.cavium.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg | expand

Commit Message

Manlunas, Felix Oct. 27, 2017, 9:37 p.m. UTC
Creating a macvtap interface with the liquidio VF driver as lower device
causes this alarming message to show up in dmesg:

    liquidio_link_ctrl_cmd_completion Unknown cmd 27

That's actually a false alarm because cmd 27 is the value of the macro
OCTNET_CMD_SET_UC_LIST which is known.  It's a control command sent from
host to NIC firmware to set the unicast MAC address list of the macvtap
lower device.

Make the false alarm go away by adding a case for OCTNET_CMD_SET_UC_LIST
in liquidio_link_ctrl_cmd_completion().

Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@cavium.com>
---
 drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Oct. 29, 2017, 3:13 a.m. UTC | #1
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 27 Oct 2017 14:37:03 -0700

> Creating a macvtap interface with the liquidio VF driver as lower device
> causes this alarming message to show up in dmesg:
> 
>     liquidio_link_ctrl_cmd_completion Unknown cmd 27
> 
> That's actually a false alarm because cmd 27 is the value of the macro
> OCTNET_CMD_SET_UC_LIST which is known.  It's a control command sent from
> host to NIC firmware to set the unicast MAC address list of the macvtap
> lower device.
> 
> Make the false alarm go away by adding a case for OCTNET_CMD_SET_UC_LIST
> in liquidio_link_ctrl_cmd_completion().
> 
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@cavium.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index b891d85..89b7820 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -143,6 +143,7 @@  void liquidio_link_ctrl_cmd_completion(void *nctrl_ptr)
 	switch (nctrl->ncmd.s.cmd) {
 	case OCTNET_CMD_CHANGE_DEVFLAGS:
 	case OCTNET_CMD_SET_MULTI_LIST:
+	case OCTNET_CMD_SET_UC_LIST:
 		break;
 
 	case OCTNET_CMD_CHANGE_MACADDR: