| Message ID | 20171005125347.otplfss4mo7hfopv@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] selftests/net: rxtimestamp: Fix an off by one | expand |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 5 Oct 2017 15:53:47 +0300 > The > should be >= so that we don't write one element beyond the end of > the array. > > Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/tools/testing/selftests/networking/timestamping/rxtimestamp.c b/tools/testing/selftests/networking/timestamping/rxtimestamp.c index 00f286661dcd..dd4162fc0419 100644 --- a/tools/testing/selftests/networking/timestamping/rxtimestamp.c +++ b/tools/testing/selftests/networking/timestamping/rxtimestamp.c @@ -341,7 +341,7 @@ int main(int argc, char **argv) return 0; case 'n': t = atoi(optarg); - if (t > ARRAY_SIZE(test_cases)) + if (t >= ARRAY_SIZE(test_cases)) error(1, 0, "Invalid test case: %d", t); all_tests = false; test_cases[t].enabled = true;
The > should be >= so that we don't write one element beyond the end of the array. Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>