| Message ID | 20170614102930.GH29394@elgon.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Jun 14, 2017 at 01:29:31PM +0300, Dan Carpenter wrote: > I'm reviewing static checker warnings where we do ERR_PTR(0), which is > the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) > here. Sometimes these bugs lead to a NULL dereference but I don't > immediately see that problem here. > > Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > You are right, it was intended to be -EINVAL. Thanks. Acked-by: Amir Vadai <amir@vadai.me>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Wed, 14 Jun 2017 13:29:31 +0300 > I'm reviewing static checker warnings where we do ERR_PTR(0), which is > the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) > here. Sometimes these bugs lead to a NULL dereference but I don't > immediately see that problem here. > > Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index 164b5ac094be..7dc5892671c8 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -94,8 +94,10 @@ static struct tcf_pedit_key_ex *tcf_pedit_keys_ex_parse(struct nlattr *nla, k++; } - if (n) + if (n) { + err = -EINVAL; goto err_out; + } return keys_ex;
I'm reviewing static checker warnings where we do ERR_PTR(0), which is the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) here. Sometimes these bugs lead to a NULL dereference but I don't immediately see that problem here. Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>