| Message ID | 20170428125608.djln5r7h4d53it5s@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> My static checker complains that we're holding a mutex on this error path. > Let's goto exit instead of returning directly. > > Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Yuval, could you review this one a bit carefully and also check that my Fixes > tag is correct because I'm not certain. Yes it seems like the right one. Thanks! Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Fri, 28 Apr 2017 15:56:09 +0300 > My static checker complains that we're holding a mutex on this error > path. Let's goto exit instead of returning directly. > > Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.c b/drivers/net/ethernet/qlogic/qed/qed_vf.c index c4c4a408b40b..11d71e5eea14 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c @@ -234,7 +234,7 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn) /* send acquire request */ rc = qed_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp)); if (rc) - return rc; + goto exit; /* copy acquire response from buffer to p_hwfn */ memcpy(&p_iov->acquire_resp, resp, sizeof(p_iov->acquire_resp));
My static checker complains that we're holding a mutex on this error path. Let's goto exit instead of returning directly. Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Yuval, could you review this one a bit carefully and also check that my Fixes tag is correct because I'm not certain.