| Message ID | 20170119090931.GA28354@lkp-ne04.lkp.intel.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2017-01-19 at 17:09 +0800, kbuild test robot wrote: > drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting value returned by memory allocation function to (struct aq_ring_buff_s *) is useless. > > Remove casting the values returned by memory allocation functions > like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc. [] > --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > @@ -21,7 +21,7 @@ static struct aq_ring_s *aq_ring_alloc(s > { > int err = 0; > > - self->buff_ring = (struct aq_ring_buff_s *) > + self->buff_ring = > kzalloc(sizeof(struct aq_ring_buff_s) * self->size, GFP_KERNEL); This should likely be kcalloc
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -21,7 +21,7 @@ static struct aq_ring_s *aq_ring_alloc(s { int err = 0; - self->buff_ring = (struct aq_ring_buff_s *) + self->buff_ring = kzalloc(sizeof(struct aq_ring_buff_s) * self->size, GFP_KERNEL); if (!self->buff_ring) {
drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting value returned by memory allocation function to (struct aq_ring_buff_s *) is useless. Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc. Semantic patch information: This makes an effort to find cases of casting of values returned by kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc, kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes the casting as it is not required. The result in the patch case may need some reformatting. Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci CC: David VomLehn <vomlehn@texas.net> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- aq_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)