From patchwork Wed Jan 18 23:02:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Bandewar X-Patchwork-Id: 716910 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v3jRX4fYXz9stc for ; Thu, 19 Jan 2017 10:12:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bandewar-net.20150623.gappssmtp.com header.i=@bandewar-net.20150623.gappssmtp.com header.b="mcfu6GNy"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbdARXMI (ORCPT ); Wed, 18 Jan 2017 18:12:08 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34610 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdARXLa (ORCPT ); Wed, 18 Jan 2017 18:11:30 -0500 Received: by mail-pf0-f193.google.com with SMTP id y143so1943940pfb.1 for ; Wed, 18 Jan 2017 15:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bandewar-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tlAfsHw8deEa2q4EEVyLcgU4yUhgXslp7iDrKE/D0y0=; b=mcfu6GNycA+6/MrIFtgP6iPocY3PykLEbVb45i5bqr5Roxx4eti3M59PApNg+zyVnp pln1KKu5yyutEp7FPaG1EMG71Q3z6IygXZ3q6aQNbVgu8xLc9H5Xb5FP8GbK8spkfyi2 7ARBDt9zTz5ybwkOUtEVD9mUQeZCeltWfPmdr56X39fOHxFT4olGzfZFBneXLimzvutG rKjBDRgufvxGiSkVbX61Uof6/s0P5AVC8LMMfIuekopBq2bwbt+njf9S1IlKYoR++Xda sxmz/WcUDJXkogIzHB6h0/Zws1lApzTUvEMwm2iZomJdf7x/FzisOOxBH4hOi8UX1xZ9 FJHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tlAfsHw8deEa2q4EEVyLcgU4yUhgXslp7iDrKE/D0y0=; b=KyU3qveSYs0QFVaZw4UewqmelBxNAYEoIWow1wqMtLCfnS7OpOWd9OrtSDsDaBlJfO 0JC6XfU4XsdaJsyEoJYSM3DjU/0bd38xZaM5iG89+rqo2XM6x2EObqk7vyRmowBohmD2 mgzY8sF3GZuMkI+aZosyO4n/ablpnqfZ/HUtk66gesI9djTqoZ8tFjQ5kSjPmr2PTlC8 FHd0+BwxZQGk7U8NHlAROEgikzGgBfCeQwJ4XbkbErsNwPys4dyJyxZKFRAJOIcT4jir 2KabY7b2TbHl5xiDP+KOGlkcd5sNedBMkHHiws79uXZXLJO0roT6pekRrK620A3MVGXO qkpQ== X-Gm-Message-State: AIkVDXI7lSXEkEeqr8wLi94185WbYL3WdilFvDd+0RaeceVR+osyMizHNMrsBJHKNlGiyg== X-Received: by 10.99.228.69 with SMTP id i5mr6701250pgk.63.1484780579008; Wed, 18 Jan 2017 15:02:59 -0800 (PST) Received: from localhost ([2620:0:1000:3012:c511:1074:5e:8342]) by smtp.gmail.com with ESMTPSA id t15sm3191617pgn.18.2017.01.18.15.02.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 18 Jan 2017 15:02:58 -0800 (PST) From: Mahesh Bandewar To: David Miller Cc: Eric Dumazet , netdev , Mahesh Bandewar , Mahesh Bandewar Subject: [PATCH next 3/3] macvlan: use netdev_is_rx_handler_busy instead of checking specific type Date: Wed, 18 Jan 2017 15:02:55 -0800 Message-Id: <20170118230255.20882-1-mahesh@bandewar.net> X-Mailer: git-send-email 2.11.0.483.g087da7b7c-goog Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mahesh Bandewar netdev_is_rx_handler_busy() check is a superset of netif_is_ipvlan_port() check and hence should be preferred. Signed-off-by: Mahesh Bandewar --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 440ab3d8adf7..cbfc1be23a0e 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1110,7 +1110,7 @@ static int macvlan_port_create(struct net_device *dev) if (dev->type != ARPHRD_ETHER || dev->flags & IFF_LOOPBACK) return -EINVAL; - if (netif_is_ipvlan_port(dev)) + if (netdev_is_rx_handler_busy(dev)) return -EBUSY; port = kzalloc(sizeof(*port), GFP_KERNEL);