| Message ID | 20160707082309.GC16742@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, Jul 7, 2016 at 1:23 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > This code generates as static checker warning because htons(ETH_P_IPV6) > is always true. From the context it looks like the && was intended to > be !=. > > Fixes: 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks. The fix is correct. Acked-by: Michael Chan <michael.chan@broadcom.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 7 Jul 2016 11:23:09 +0300 > This code generates as static checker warning because htons(ETH_P_IPV6) > is always true. From the context it looks like the && was intended to > be !=. > > Fixes: 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 70b148a..659faa6 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -997,7 +997,7 @@ static struct sk_buff *bnxt_gro_func_5731x(struct bnxt_tpa_info *tpa_info, * correct protocol ID, it must be a loopback packet where * the offsets are off by 4. */ - if (proto != htons(ETH_P_IP) && proto && htons(ETH_P_IPV6)) + if (proto != htons(ETH_P_IP) && proto != htons(ETH_P_IPV6)) loopback = true; } if (loopback) {
This code generates as static checker warning because htons(ETH_P_IPV6) is always true. From the context it looks like the && was intended to be !=. Fixes: 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>