diff mbox

[net-next] rxrpc: checking for IS_ERR() instead of NULL

Message ID 20160618084403.GC21713@mwanda
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

Dan Carpenter June 18, 2016, 8:44 a.m. UTC 
rxrpc_lookup_peer_rcu() returns NULL on error, it never returns error
pointers.

Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table and RCU')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

David Howells June 21, 2016, 8:47 a.m. UTC | #1 
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> rxrpc_lookup_peer_rcu() returns NULL on error, it never returns error
> pointers.
> 
> Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table and RCU')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.
diff mbox

Patch

diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index 47fb167..e11e4d7 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -639,7 +639,7 @@  static struct rxrpc_connection *rxrpc_conn_from_local(struct rxrpc_local *local,
 	rxrpc_get_addr_from_skb(local, skb, &srx);
 	rcu_read_lock();
 	peer = rxrpc_lookup_peer_rcu(local, &srx);
-	if (IS_ERR(peer))
+	if (!peer)
 		goto cant_find_peer;
 
 	trans = rxrpc_find_transport(local, peer);