diff mbox

rocker: fix rocker_world_port_obj_vlan_add()

Message ID 20160223093752.GA4030@mwanda
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Dan Carpenter Feb. 23, 2016, 9:37 a.m. UTC 
We were changing return values and accidentally made
rocker_world_port_obj_vlan_add() into a no-op.

Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Jiri Pirko Feb. 23, 2016, 9:39 a.m. UTC | #1 
Tue, Feb 23, 2016 at 10:37:52AM CET, dan.carpenter@oracle.com wrote:
>We were changing return values and accidentally made
>rocker_world_port_obj_vlan_add() into a no-op.
>
>Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oops. Thanks for the fix.

Acked-by: Jiri Pirko <jiri@mellanox.com>
David Miller Feb. 23, 2016, 6:12 p.m. UTC | #2 
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 23 Feb 2016 12:37:52 +0300

> We were changing return values and accidentally made
> rocker_world_port_obj_vlan_add() into a no-op.
> 
> Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index acafbf8..28b775e 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -1598,7 +1598,6 @@  rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port,
 
 	if (!wops->port_obj_vlan_add)
 		return -EOPNOTSUPP;
-		return 0;
 	return wops->port_obj_vlan_add(rocker_port, vlan, trans);
 }