| Message ID | 20160113122823.GD19993@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> On Jan 13, 2016, at 2:28 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > There is a missing break statement so we always return -EOPNOTSUPP. > > Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Elad Raz <eladr@mellanox.com> > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > index ffe894e..45479ef 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev, > case SWITCHDEV_OBJ_ID_PORT_MDB: > err = mlxsw_sp_port_mdb_del(mlxsw_sp_port, > SWITCHDEV_OBJ_PORT_MDB(obj)); > + break; > default: > err = -EOPNOTSUPP; > break;
Wed, Jan 13, 2016 at 01:28:23PM CET, dan.carpenter@oracle.com wrote: >There is a missing break statement so we always return -EOPNOTSUPP. > >Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support') >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jiri Pirko <jiri@mellanox.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Wed, 13 Jan 2016 15:28:23 +0300 > There is a missing break statement so we always return -EOPNOTSUPP. > > Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index ffe894e..45479ef 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev, case SWITCHDEV_OBJ_ID_PORT_MDB: err = mlxsw_sp_port_mdb_del(mlxsw_sp_port, SWITCHDEV_OBJ_PORT_MDB(obj)); + break; default: err = -EOPNOTSUPP; break;
There is a missing break statement so we always return -EOPNOTSUPP. Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>