diff mbox

[net-next,1/1] amd-xgbe: fix unused variable compilation warning in phylib driver

Message ID 20140607090748.GA11521@electric-eye.fr.zoreil.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Francois Romieu June 7, 2014, 9:07 a.m. UTC
Fix following compilation warning:
[...]
  CC      drivers/net/phy/amd-xgbe-phy.o
drivers/net/phy/amd-xgbe-phy.c:1353:30: warning:
‘amd_xgbe_phy_ids’ defined but not used [-Wunused-variable]
 static struct mdio_device_id amd_xgbe_phy_ids[] = {
                              ^
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 drivers/net/phy/amd-xgbe-phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Lendacky June 9, 2014, 7:07 p.m. UTC | #1
On 06/07/2014 04:07 AM, Francois Romieu wrote:
> Fix following compilation warning:
> [...]
>    CC      drivers/net/phy/amd-xgbe-phy.o
> drivers/net/phy/amd-xgbe-phy.c:1353:30: warning:
> ‘amd_xgbe_phy_ids’ defined but not used [-Wunused-variable]
>   static struct mdio_device_id amd_xgbe_phy_ids[] = {
>                                ^
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/net/phy/amd-xgbe-phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/amd-xgbe-phy.c b/drivers/net/phy/amd-xgbe-phy.c
> index d4b1c81..b57c224 100644
> --- a/drivers/net/phy/amd-xgbe-phy.c
> +++ b/drivers/net/phy/amd-xgbe-phy.c
> @@ -1350,7 +1350,7 @@ static void __exit amd_xgbe_phy_exit(void)
>   module_init(amd_xgbe_phy_init);
>   module_exit(amd_xgbe_phy_exit);
>
> -static struct mdio_device_id amd_xgbe_phy_ids[] = {
> +static struct mdio_device_id __maybe_unused amd_xgbe_phy_ids[] = {
>   	{ XGBE_PHY_ID, XGBE_PHY_MASK },
>   	{ }
>   };
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller June 11, 2014, 7:15 a.m. UTC | #2
From: Francois Romieu <romieu@fr.zoreil.com>

Date: Sat, 7 Jun 2014 11:07:48 +0200

> Fix following compilation warning:

> [...]

>   CC      drivers/net/phy/amd-xgbe-phy.o

> drivers/net/phy/amd-xgbe-phy.c:1353:30: warning:

> ‘amd_xgbe_phy_ids’ defined but not used [-Wunused-variable]

>  static struct mdio_device_id amd_xgbe_phy_ids[] = {

>                               ^

> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>


Applied.
diff mbox

Patch

diff --git a/drivers/net/phy/amd-xgbe-phy.c b/drivers/net/phy/amd-xgbe-phy.c
index d4b1c81..b57c224 100644
--- a/drivers/net/phy/amd-xgbe-phy.c
+++ b/drivers/net/phy/amd-xgbe-phy.c
@@ -1350,7 +1350,7 @@  static void __exit amd_xgbe_phy_exit(void)
 module_init(amd_xgbe_phy_init);
 module_exit(amd_xgbe_phy_exit);
 
-static struct mdio_device_id amd_xgbe_phy_ids[] = {
+static struct mdio_device_id __maybe_unused amd_xgbe_phy_ids[] = {
 	{ XGBE_PHY_ID, XGBE_PHY_MASK },
 	{ }
 };