| Message ID | 20131107074445.GD21844@elgon.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, Nov 07, 2013 at 10:44:45AM +0300, Dan Carpenter wrote: > We recently added a new error path and it needs a dev_put(). > > Fixes: 7adac1ec8198 ('6lowpan: Only make 6lowpan links to IEEE802154 devices') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Compile tested only. Please review carefully. > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > index 9497c6f..426b5df 100644 > --- a/net/ieee802154/6lowpan.c > +++ b/net/ieee802154/6lowpan.c > @@ -1358,8 +1358,10 @@ static int lowpan_newlink(struct net *src_net, struct net_device *dev, > real_dev = dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK])); > if (!real_dev) > return -ENODEV; > - if (real_dev->type != ARPHRD_IEEE802154) > + if (real_dev->type != ARPHRD_IEEE802154) { > + dev_put(real_dev); > return -EINVAL; > + } looks correct for me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 7 Nov 2013 10:44:45 +0300 > We recently added a new error path and it needs a dev_put(). > > Fixes: 7adac1ec8198 ('6lowpan: Only make 6lowpan links to IEEE802154 devices') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 9497c6f..426b5df 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -1358,8 +1358,10 @@ static int lowpan_newlink(struct net *src_net, struct net_device *dev, real_dev = dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK])); if (!real_dev) return -ENODEV; - if (real_dev->type != ARPHRD_IEEE802154) + if (real_dev->type != ARPHRD_IEEE802154) { + dev_put(real_dev); return -EINVAL; + } lowpan_dev_info(dev)->real_dev = real_dev; lowpan_dev_info(dev)->fragment_tag = 0;
We recently added a new error path and it needs a dev_put(). Fixes: 7adac1ec8198 ('6lowpan: Only make 6lowpan links to IEEE802154 devices') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Compile tested only. Please review carefully. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html