| Message ID | 20110601163153.GB2784@psychotron.redhat.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
Le 01/06/2011 18:31, Jiri Pirko a écrit : > This patch allows to reset failure counters for all enslaved devices. Hi Jiri, Why do we need a way to reset those counters? What is the problem with having those counters monotonically increase until the system is rebooted? Do we have a way to reset other network statistics (/sys/class/net/eth0/statistics/* for example)? Except from this "do we need this feature" question, the code sounds good to me. Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr> Nicolas. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wed, Jun 01, 2011 at 09:23:11PM CEST, nicolas.2p.debian@gmail.com wrote: >Le 01/06/2011 18:31, Jiri Pirko a écrit : >>This patch allows to reset failure counters for all enslaved devices. > >Hi Jiri, > >Why do we need a way to reset those counters? What is the problem >with having those counters monotonically increase until the system is >rebooted? Do we have a way to reset other network statistics >(/sys/class/net/eth0/statistics/* for example)? Well, it's handy to be able to clear this counters when you resolve a problem so future issues are crearly seen as non-zero. > >Except from this "do we need this feature" question, the code sounds good to me. > >Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr> > > Nicolas. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Pirko <jpirko@redhat.com> Date: Wed, 1 Jun 2011 22:08:55 +0200 > Wed, Jun 01, 2011 at 09:23:11PM CEST, nicolas.2p.debian@gmail.com wrote: >>Le 01/06/2011 18:31, Jiri Pirko a écrit : >>>This patch allows to reset failure counters for all enslaved devices. >> >>Hi Jiri, >> >>Why do we need a way to reset those counters? What is the problem >>with having those counters monotonically increase until the system is >>rebooted? Do we have a way to reset other network statistics >>(/sys/class/net/eth0/statistics/* for example)? > > Well, it's handy to be able to clear this counters when you resolve > a problem so future issues are crearly seen as non-zero. We don't allow this in any way for netdev counters, for good reasons, so please don't add things like this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wed, Jun 01, 2011 at 10:12:43PM CEST, davem@davemloft.net wrote: >From: Jiri Pirko <jpirko@redhat.com> >Date: Wed, 1 Jun 2011 22:08:55 +0200 > >> Wed, Jun 01, 2011 at 09:23:11PM CEST, nicolas.2p.debian@gmail.com wrote: >>>Le 01/06/2011 18:31, Jiri Pirko a écrit : >>>>This patch allows to reset failure counters for all enslaved devices. >>> >>>Hi Jiri, >>> >>>Why do we need a way to reset those counters? What is the problem >>>with having those counters monotonically increase until the system is >>>rebooted? Do we have a way to reset other network statistics >>>(/sys/class/net/eth0/statistics/* for example)? >> >> Well, it's handy to be able to clear this counters when you resolve >> a problem so future issues are crearly seen as non-zero. > >We don't allow this in any way for netdev counters, for good reasons, >so please don't add things like this. > Well technically this is not netdev counter directly. But fair enough. Thanks. Jirka -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt index 675612f..7a8da01 100644 --- a/Documentation/networking/bonding.txt +++ b/Documentation/networking/bonding.txt @@ -782,6 +782,15 @@ resend_igmp This option was added for bonding version 3.7.0. +reset_failure_counters + + This write-only control file will zero failure counters for + all slaves. Note there is no appropriate module parameter for this + since it would not make much sense. + Write any value to perform reset. + + This option was added for bonding version 3.7.2. + 3. Configuring Bonding Devices ============================== diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c index 88fcb25..342b4ed 100644 --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c @@ -1572,6 +1572,33 @@ out: static DEVICE_ATTR(resend_igmp, S_IRUGO | S_IWUSR, bonding_show_resend_igmp, bonding_store_resend_igmp); +static ssize_t +bonding_store_reset_failure_counters(struct device *d, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct slave *slave; + int i; + struct bonding *bond = to_bond(d); + + if (!rtnl_trylock()) + return restart_syscall(); + + pr_info("%s: Resetting failure counters.\n", bond->dev->name); + + read_lock(&bond->lock); + bond_for_each_slave(bond, slave, i) + slave->link_failure_count = 0; + read_unlock(&bond->lock); + + rtnl_unlock(); + + return count; +} + +static DEVICE_ATTR(reset_failure_counters, S_IWUSR, NULL, + bonding_store_reset_failure_counters); + static struct attribute *per_bond_attrs[] = { &dev_attr_slaves.attr, &dev_attr_mode.attr, @@ -1600,6 +1627,7 @@ static struct attribute *per_bond_attrs[] = { &dev_attr_queue_id.attr, &dev_attr_all_slaves_active.attr, &dev_attr_resend_igmp.attr, + &dev_attr_reset_failure_counters.attr, NULL, }; diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h index ea1d005..62528f8 100644 --- a/drivers/net/bonding/bonding.h +++ b/drivers/net/bonding/bonding.h @@ -24,8 +24,8 @@ #include "bond_3ad.h" #include "bond_alb.h" -#define DRV_VERSION "3.7.1" -#define DRV_RELDATE "April 27, 2011" +#define DRV_VERSION "3.7.2" +#define DRV_RELDATE "Jun 1, 2011" #define DRV_NAME "bonding" #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver"
This patch allows to reset failure counters for all enslaved devices. Signed-off-by: Jiri Pirko <jpirko@redhat.com> v1->v2: added version bump added version note to doc moved and adjusted printk --- Documentation/networking/bonding.txt | 9 +++++++++ drivers/net/bonding/bond_sysfs.c | 28 ++++++++++++++++++++++++++++ drivers/net/bonding/bonding.h | 4 ++-- 3 files changed, 39 insertions(+), 2 deletions(-)