| Message ID | 20090727134616.12897.7639.stgit@jazzy.zrh.corp.google.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Monday 2009-07-27 15:46, Hannes Eder wrote: > >Now all printk messages from IPVS are prefixed with "IPVS:". > >+#define EnterFunction(level) \ >+ do { \ >+ if (level <= ip_vs_get_debug_level()) \ >+ printk(KERN_DEBUG "IPVS: Enter: %s, %s line %i\n", \ >+ __func__, __FILE__, __LINE__); \ >+ } while (0) >+#define LeaveFunction(level) \ >+ do { \ >+ if (level <= ip_vs_get_debug_level()) \ >+ printk(KERN_DEBUG "IPVS: Leave: %s, %s line %i\n", \ >+ __func__, __FILE__, __LINE__); \ >+ } while (0) I think you should rather make use of pr_fmt: <before any #includes> #define pr_fmt(x) "IPVS: " x And then use pr_<level>("Elvis has left the building") in code. This will add IPVS: automatically to all pr_* calls, alleviating the need to manually type it into all printks. Of course, if you only want it for the two defines here, scrap my idea :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 27, 2009 at 20:14, Jan Engelhardt<jengelh@medozas.de> wrote: > > On Monday 2009-07-27 15:46, Hannes Eder wrote: >> >>Now all printk messages from IPVS are prefixed with "IPVS:". >> >>+#define EnterFunction(level) \ >>+ do { \ >>+ if (level <= ip_vs_get_debug_level()) \ >>+ printk(KERN_DEBUG "IPVS: Enter: %s, %s line %i\n", \ >>+ __func__, __FILE__, __LINE__); \ >>+ } while (0) >>+#define LeaveFunction(level) \ >>+ do { \ >>+ if (level <= ip_vs_get_debug_level()) \ >>+ printk(KERN_DEBUG "IPVS: Leave: %s, %s line %i\n", \ >>+ __func__, __FILE__, __LINE__); \ >>+ } while (0) > > I think you should rather make use of pr_fmt: > > <before any #includes> > #define pr_fmt(x) "IPVS: " x > > And then use pr_<level>("Elvis has left the building") in code. This > will add IPVS: automatically to all pr_* calls, alleviating the need > to manually type it into all printks. I like this idea. I'll come up with an extra patch, it does not fit into this series anyway. > Of course, if you only want it for the two defines here, scrap > my idea :) > Cheers, -Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index e01cc2d..e03524e 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h @@ -161,18 +161,18 @@ static inline const char *ip_vs_dbg_addr(int af, char *buf, size_t buf_len, } while (0) #ifdef CONFIG_IP_VS_DEBUG -#define EnterFunction(level) \ - do { \ - if (level <= ip_vs_get_debug_level()) \ - printk(KERN_DEBUG "Enter: %s, %s line %i\n", \ - __func__, __FILE__, __LINE__); \ - } while (0) -#define LeaveFunction(level) \ - do { \ - if (level <= ip_vs_get_debug_level()) \ - printk(KERN_DEBUG "Leave: %s, %s line %i\n", \ - __func__, __FILE__, __LINE__); \ - } while (0) +#define EnterFunction(level) \ + do { \ + if (level <= ip_vs_get_debug_level()) \ + printk(KERN_DEBUG "IPVS: Enter: %s, %s line %i\n", \ + __func__, __FILE__, __LINE__); \ + } while (0) +#define LeaveFunction(level) \ + do { \ + if (level <= ip_vs_get_debug_level()) \ + printk(KERN_DEBUG "IPVS: Leave: %s, %s line %i\n", \ + __func__, __FILE__, __LINE__); \ + } while (0) #else #define EnterFunction(level) do {} while (0) #define LeaveFunction(level) do {} while (0)