| Message ID | 20090727090741.16509.35291.stgit@jazzy.zrh.corp.google.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jul 27, 2009 at 11:08:34AM +0200, Hannes Eder wrote: > No more guessing, how much memory is used by IPVS for a connection. I like that. > Signed-off-by: Hannes Eder <heder@google.com> Signed-off-by: Simon Horman <horms@verge.net.au> > --- > net/netfilter/ipvs/ip_vs_core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c > index b021464..5b0997c 100644 > --- a/net/netfilter/ipvs/ip_vs_core.c > +++ b/net/netfilter/ipvs/ip_vs_core.c > @@ -1475,7 +1475,8 @@ static int __init ip_vs_init(void) > goto cleanup_conn; > } > > - IP_VS_INFO("ipvs loaded.\n"); > + IP_VS_INFO("ipvs loaded (using %Zd bytes/connection).\n", > + sizeof(struct ip_vs_conn)); > return ret; > > cleanup_conn: > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hannes Eder a écrit : > No more guessing, how much memory is used by IPVS for a connection. > > Signed-off-by: Hannes Eder <heder@google.com> > --- > net/netfilter/ipvs/ip_vs_core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c > index b021464..5b0997c 100644 > --- a/net/netfilter/ipvs/ip_vs_core.c > +++ b/net/netfilter/ipvs/ip_vs_core.c > @@ -1475,7 +1475,8 @@ static int __init ip_vs_init(void) > goto cleanup_conn; > } > > - IP_VS_INFO("ipvs loaded.\n"); > + IP_VS_INFO("ipvs loaded (using %Zd bytes/connection).\n", > + sizeof(struct ip_vs_conn)); > return ret; > > cleanup_conn: Well, ip_vs_conn_cache uses SLAB_HWCACHE_ALIGN, so this should be rounded up to L1 cache size. Or add "at least" like in line 1080 of net/netfilter/ipvs/ip_vs_conn.c : IP_VS_DBG(0, "Each connection entry needs %Zd bytes at least\n", sizeof(struct ip_vs_conn)); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 27, 2009 at 11:25, Eric Dumazet<eric.dumazet@gmail.com> wrote: > Well, ip_vs_conn_cache uses SLAB_HWCACHE_ALIGN, so this should be rounded up > to L1 cache size. Or add "at least" like in line 1080 > of net/netfilter/ipvs/ip_vs_conn.c : > > IP_VS_DBG(0, "Each connection entry needs %Zd bytes at least\n", > sizeof(struct ip_vs_conn)); Good point. Is there an easy way to figure out how much memory is wasted for alignment by the slab allocator? Otherwise I vote for the "at least" approach. -Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index b021464..5b0997c 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -1475,7 +1475,8 @@ static int __init ip_vs_init(void) goto cleanup_conn; } - IP_VS_INFO("ipvs loaded.\n"); + IP_VS_INFO("ipvs loaded (using %Zd bytes/connection).\n", + sizeof(struct ip_vs_conn)); return ret; cleanup_conn:
No more guessing, how much memory is used by IPVS for a connection. Signed-off-by: Hannes Eder <heder@google.com> --- net/netfilter/ipvs/ip_vs_core.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html