From patchwork Tue Jun 16 09:56:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 28728 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id A009AB7120 for ; Tue, 16 Jun 2009 19:57:08 +1000 (EST) Received: by ozlabs.org (Postfix) id 8F8FFDDD1C; Tue, 16 Jun 2009 19:57:08 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 21610DDD0B for ; Tue, 16 Jun 2009 19:57:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755172AbZFPJ45 (ORCPT ); Tue, 16 Jun 2009 05:56:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751831AbZFPJ45 (ORCPT ); Tue, 16 Jun 2009 05:56:57 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41503 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbZFPJ44 (ORCPT ); Tue, 16 Jun 2009 05:56:56 -0400 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id A5B5EC8C0F0; Tue, 16 Jun 2009 02:56:59 -0700 (PDT) Date: Tue, 16 Jun 2009 02:56:59 -0700 (PDT) Message-Id: <20090616.025659.224075454.davem@davemloft.net> To: mingo@elte.hu Cc: alan@lxorguk.ukuu.org.uk, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT]: Networking From: David Miller In-Reply-To: <20090616094813.GA1686@elte.hu> References: <20090616.021955.243374916.davem@davemloft.net> <20090616104417.657d6682@lxorguk.ukuu.org.uk> <20090616094813.GA1686@elte.hu> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ingo Molnar Date: Tue, 16 Jun 2009 11:48:13 +0200 > I think David's larger point was that what looked to me like more > widespread breakage was in fact limited to [a]x25, a comparatively > rarely used (and rarely tested) corner of the kernel. > > I turned them off and that solved the problems here. (and i suspect > the real fix wont be far away either) Thanks everyone. This code path has been broken, basically, forever. It does a lock_sock() from a timer, which has that might_sleep() check, and essentially always has. It would have warned this way years ago if someone had triggered it. The code has been this way forever, so something else changed to start triggering this on you. I still am curious what in the world opens those sockets for you, nothing normal should be doing so. Can you satisfy my curiosity by turning X25 back on and booting with this patch? Thanks. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index ed80af8..5214a38 100644 --- a/net/x25/af_x25.c +++ b/net/x25/af_x25.c @@ -494,6 +494,10 @@ static int x25_create(struct net *net, struct socket *sock, int protocol) struct x25_sock *x25; int rc = -ESOCKTNOSUPPORT; +#if 1 + printk(KERN_INFO "[%s:%d]: Creates X25 socket.\n", + current->comm, current->pid); +#endif if (net != &init_net) return -EAFNOSUPPORT;