| Message ID | 20090530034004.GA20516@gondor.apana.org.au |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
ccing cxgb3i driver maitainer. Herbert Xu wrote: > Hi: > > [SCSI] cxgb3i: Include net/dst.h for struct dst_cache > > This driver needs dst_cache->dev so it should include net/dst.h > to ensure that it builds. While net/tcp.h probably includes it > already, we shouldn't rely on that since there is no guarantee > that this won't change in future. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> > > diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c > index 9212400..8b49731 100644 > --- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c > +++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c > @@ -13,6 +13,7 @@ > > #include <linux/inet.h> > #include <linux/crypto.h> > +#include <net/dst.h> > #include <net/tcp.h> > #include <scsi/scsi_cmnd.h> > #include <scsi/scsi_device.h> > Looks ok. Acked-by: Mike Christie <michaelc@cs.wisc.edu> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c index 9212400..8b49731 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c +++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c @@ -13,6 +13,7 @@ #include <linux/inet.h> #include <linux/crypto.h> +#include <net/dst.h> #include <net/tcp.h> #include <scsi/scsi_cmnd.h> #include <scsi/scsi_device.h>
Hi: [SCSI] cxgb3i: Include net/dst.h for struct dst_cache This driver needs dst_cache->dev so it should include net/dst.h to ensure that it builds. While net/tcp.h probably includes it already, we shouldn't rely on that since there is no guarantee that this won't change in future. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks,