From patchwork Sun May 3 09:55:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 26815 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 2440EB6F34 for ; Sun, 3 May 2009 19:56:58 +1000 (EST) Received: by ozlabs.org (Postfix) id 0FBF7DDE07; Sun, 3 May 2009 19:56:58 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 8D197DDE06 for ; Sun, 3 May 2009 19:56:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbZECJ4v (ORCPT ); Sun, 3 May 2009 05:56:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752347AbZECJ4v (ORCPT ); Sun, 3 May 2009 05:56:51 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37723 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbZECJ4u (ORCPT ); Sun, 3 May 2009 05:56:50 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n439tA0S011463; Sun, 3 May 2009 05:55:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n439t9lF027855; Sun, 3 May 2009 05:55:09 -0400 Received: from localhost (vpn-10-70.str.redhat.com [10.32.10.70]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n439t77x025227; Sun, 3 May 2009 05:55:07 -0400 Date: Sun, 3 May 2009 11:55:06 +0200 From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, lkundrak@v3.sk, jeff@garzik.org, akpm@linux-foundation.org Subject: [PATCH] ne2k-pci: use dev->addr_len instead of "6" Message-ID: <20090503095506.GA6177@psychotron.englab.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Spotted a tiny ugliness in a recently posted patch. This patch cuts it out. Jirka Signed-off-by: Jiri Pirko drivers/net/ne2k-pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ne2k-pci.c b/drivers/net/ne2k-pci.c index 7d83896..3fcebb7 100644 --- a/drivers/net/ne2k-pci.c +++ b/drivers/net/ne2k-pci.c @@ -374,7 +374,7 @@ static int __devinit ne2k_pci_init_one (struct pci_dev *pdev, dev->ethtool_ops = &ne2k_pci_ethtool_ops; NS8390_init(dev, 0); - memcpy(dev->dev_addr, SA_prom, 6); + memcpy(dev->dev_addr, SA_prom, dev->addr_len); memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len); i = register_netdev(dev);