From patchwork Mon Mar 2 09:53:15 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 23930 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id F3201DDF4A for ; Mon, 2 Mar 2009 20:53:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758268AbZCBJxb (ORCPT ); Mon, 2 Mar 2009 04:53:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758237AbZCBJxb (ORCPT ); Mon, 2 Mar 2009 04:53:31 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:55953 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754544AbZCBJxa (ORCPT ); Mon, 2 Mar 2009 04:53:30 -0500 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 32CEDC8D985; Mon, 2 Mar 2009 01:53:15 -0800 (PST) Date: Mon, 02 Mar 2009 01:53:15 -0800 (PST) Message-Id: <20090302.015315.181629191.davem@davemloft.net> To: dave@thedillows.org Cc: ben@decadent.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH v2] typhoon: Use request_firmware() From: David Miller In-Reply-To: <1235980579.23967.2.camel@localhost.localdomain> References: <20090301.201123.112634333.davem@davemloft.net> <20090301.202929.81587113.davem@davemloft.net> <1235980579.23967.2.camel@localhost.localdomain> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Dillow Date: Mon, 02 Mar 2009 02:56:19 -0500 > On Sun, 2009-03-01 at 20:29 -0800, David Miller wrote: > > + > > + typhoon_fw_image = kmalloc(typhoon_fw->size, GFP_KERNEL); > > + if (!typhoon_fw_image) { > > + err = -ENOMEM; > > + goto out_err; > > } > > You never copied the image into the kmalloc'd memory, so you upload > garbage. > > Fix that and I think it will be OK. Good catch, I've checked in the following fix: typhoon: Add missing firmware copy. Noticed by David Dillow. Signed-off-by: David S. Miller --- drivers/net/typhoon.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index ec2541c..9bba787 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -1377,6 +1377,7 @@ typhoon_request_firmware(struct typhoon *tp) err = -ENOMEM; goto out_err; } + memcpy(typhoon_fw_image, typhoon_fw->data, typhoon_fw->size); return 0;