From patchwork Sun Jan 18 22:50:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 19229 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id EC467DDF3E for ; Mon, 19 Jan 2009 09:51:00 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbZARWuv (ORCPT ); Sun, 18 Jan 2009 17:50:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753263AbZARWuu (ORCPT ); Sun, 18 Jan 2009 17:50:50 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:40914 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753089AbZARWut (ORCPT ); Sun, 18 Jan 2009 17:50:49 -0500 Received: from gondolin.me.apana.org.au ([192.168.0.6]) by arnor.apana.org.au with esmtp (Exim 4.63 #1 (Debian)) id 1LOgTc-0006xi-Dq; Mon, 19 Jan 2009 09:50:44 +1100 Received: from herbert by gondolin.me.apana.org.au with local (Exim 4.69) (envelope-from ) id 1LOgTZ-0007vJ-1Z; Mon, 19 Jan 2009 09:50:41 +1100 Date: Mon, 19 Jan 2009 09:50:40 +1100 From: Herbert Xu To: Divy Le Ray Cc: davem@davemloft.net, netdev@vger.kernel.org, Steve Wise Subject: Re: cxgb3: Replace LRO with GRO Message-ID: <20090118225040.GA30418@gondor.apana.org.au> References: <20090115235803.GA9000@gondor.apana.org.au> <49704015.6020503@chelsio.com> <20090116085645.GA14678@gondor.apana.org.au> <49706B87.7080806@chelsio.com> <20090117050839.GA24215@gondor.apana.org.au> <4971BCDE.50600@chelsio.com> <20090117130827.GA17896@gondor.apana.org.au> <49739226.3020104@chelsio.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <49739226.3020104@chelsio.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 18, 2009 at 12:33:42PM -0800, Divy Le Ray wrote: > > Thanks for the patch. It does improve the performance. > I'm now getting about 5.3Gbs. Thanks for testing Divy! > Here is a oprofile output: > 33.929900 copy_user_generic_unrolled vmlinux > 7.150300 process_responses cxgb3.ko > 6.261100 refill_fl cxgb3.ko > 6.181700 memcpy vmlinux I wonder why this is still up there. Maybe this patch will help? Cheers, diff --git a/net/core/dev.c b/net/core/dev.c index 3742397..3cc19fa 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2554,7 +2554,8 @@ struct sk_buff *napi_fraginfo_skb(struct napi_struct *napi, BUG_ON(info->nr_frags > MAX_SKB_FRAGS); skb_shinfo(skb)->nr_frags = info->nr_frags; - memcpy(skb_shinfo(skb)->frags, info->frags, sizeof(info->frags)); + memcpy(skb_shinfo(skb)->frags, info->frags, + info->nr_frags * sizeof(*info->frags)); skb->data_len = info->len; skb->len += info->len;