diff mbox

sumgem problems with initializiation order at a 1000SX SERDES card

Message ID 20081126.011809.241693537.davem@davemloft.net
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

David Miller Nov. 26, 2008, 9:18 a.m. UTC 
From: Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Date: Tue, 25 Nov 2008 11:30:29 +0100

> PS: There is only one "writeb" call in the code to reset the PCS, but the 
> value is read with a readl. Typo ?

That is definitely a bug, which I've fixed as follows.

I don't know about the rest of your report at this point, sorry.

sungem: Fix PCS_MIICTRL register write in gem_init_phy().

Use writel not writeb.

Noticed by Hermann Lauer.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/sungem.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff mbox

Patch

diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 4291458..1349e41 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1714,7 +1714,7 @@  static void gem_init_phy(struct gem *gp)
 		/* Reset PCS unit. */
 		val = readl(gp->regs + PCS_MIICTRL);
 		val |= PCS_MIICTRL_RST;
-		writeb(val, gp->regs + PCS_MIICTRL);
+		writel(val, gp->regs + PCS_MIICTRL);
 
 		limit = 32;
 		while (readl(gp->regs + PCS_MIICTRL) & PCS_MIICTRL_RST) {