| Message ID | 20081013060615.GB29358@colo.lackof.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Grant Grundler <grundler@parisc-linux.org> Date: Mon, 13 Oct 2008 00:06:15 -0600 > QLGE driver only supports 4k, 8k, and 64k pages. > Default page size on ia64 is 16k. Compile fails with: > drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function) > > Patch below makes the cause of the compile failure obvious. > (Better would be to support 16k pages but I don't have the HW or interest.) > > Signed-off-by: Grant Grundler <grundler@parisc-linux.org> I would rather, at this point, give the qlge guys a day or two to try and add support for other page sizes if that is possible. If it isn't possible, I'd rather see a Kconfig guard, a compile failure is really not acceptable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h index c37ea43..cf68503 100644 --- a/drivers/net/qlge/qlge.h +++ b/drivers/net/qlge/qlge.h @@ -60,6 +60,8 @@ #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) #elif (PAGE_SHIFT == 16) /* 64k pages */ #define TX_DESC_PER_OAL 0 +#else +#error QLGE Driver only supports 4k, 8k, or 64k CPU page size. #endif #define DB_PAGE_SIZE 4096
QLGE driver only supports 4k, 8k, and 64k pages. Default page size on ia64 is 16k. Compile fails with: drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function) Patch below makes the cause of the compile failure obvious. (Better would be to support 16k pages but I don't have the HW or interest.) Signed-off-by: Grant Grundler <grundler@parisc-linux.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html