diff mbox series

[net,3/4] fsl/fman: detect FMan erratum A050385

Message ID 1583250939-24645-4-git-send-email-madalin.bucur@oss.nxp.com
State Changes Requested
Delegated to: David Miller
Headers show
Series QorIQ DPAA FMan erratum A050385 workaround | expand

Commit Message

Madalin Bucur (OSS) March 3, 2020, 3:55 p.m. UTC 
From: Madalin Bucur <madalin.bucur@nxp.com>

Detect the presence of the A050385 erratum.

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/ethernet/freescale/fman/fman.c | 18 ++++++++++++++++++
 drivers/net/ethernet/freescale/fman/fman.h | 10 ++++++++++
 2 files changed, 28 insertions(+)

Comments

David Miller March 3, 2020, 11:52 p.m. UTC | #1 
From: Madalin Bucur <madalin.bucur@oss.nxp.com>
Date: Tue,  3 Mar 2020 17:55:38 +0200

> @@ -37,6 +38,11 @@
>  #include <linux/interrupt.h>
>  #include <linux/of_irq.h>
>  
> +#ifdef CONFIG_ARM64
> +/* only some ARM64 platforms are affected */
> +#define DPAA_FMAN_ERRATUM_A050385 1
> +#endif

Please use Kconfig for expressing this.

Create a CONFIG_DPAA_ERRATUM_A050385 and 'select' it in the
driver Kconfig entry when ARM64 is true.

Thank you.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
index 934111def0be..a673917b7411 100644
--- a/drivers/net/ethernet/freescale/fman/fman.c
+++ b/drivers/net/ethernet/freescale/fman/fman.c
@@ -1,5 +1,6 @@ 
 /*
  * Copyright 2008-2015 Freescale Semiconductor Inc.
+ * Copyright 2020 NXP
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
@@ -566,6 +567,10 @@  struct fman_cfg {
 	u32 qmi_def_tnums_thresh;
 };
 
+#ifdef DPAA_FMAN_ERRATUM_A050385
+static bool fman_has_err_a050385;
+#endif
+
 static irqreturn_t fman_exceptions(struct fman *fman,
 				   enum fman_exceptions exception)
 {
@@ -2518,6 +2523,14 @@  struct fman *fman_bind(struct device *fm_dev)
 }
 EXPORT_SYMBOL(fman_bind);
 
+#ifdef DPAA_FMAN_ERRATUM_A050385
+bool fman_has_errata_a050385(void)
+{
+	return fman_has_err_a050385;
+}
+EXPORT_SYMBOL(fman_has_errata_a050385);
+#endif
+
 static irqreturn_t fman_err_irq(int irq, void *handle)
 {
 	struct fman *fman = (struct fman *)handle;
@@ -2845,6 +2858,11 @@  static struct fman *read_dts_node(struct platform_device *of_dev)
 		goto fman_free;
 	}
 
+#ifdef DPAA_FMAN_ERRATUM_A050385
+	fman_has_err_a050385 =
+		of_property_read_bool(fm_node, "fsl,erratum-a050385");
+#endif
+
 	return fman;
 
 fman_node_put:
diff --git a/drivers/net/ethernet/freescale/fman/fman.h b/drivers/net/ethernet/freescale/fman/fman.h
index 935c317fa696..7b14ef4c306d 100644
--- a/drivers/net/ethernet/freescale/fman/fman.h
+++ b/drivers/net/ethernet/freescale/fman/fman.h
@@ -1,5 +1,6 @@ 
 /*
  * Copyright 2008-2015 Freescale Semiconductor Inc.
+ * Copyright 2020 NXP
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
@@ -37,6 +38,11 @@ 
 #include <linux/interrupt.h>
 #include <linux/of_irq.h>
 
+#ifdef CONFIG_ARM64
+/* only some ARM64 platforms are affected */
+#define DPAA_FMAN_ERRATUM_A050385 1
+#endif
+
 /* FM Frame descriptor macros  */
 /* Frame queue Context Override */
 #define FM_FD_CMD_FCO                   0x80000000
@@ -398,6 +404,10 @@  u16 fman_get_max_frm(void);
 
 int fman_get_rx_extra_headroom(void);
 
+#ifdef DPAA_FMAN_ERRATUM_A050385
+bool fman_has_errata_a050385(void);
+#endif
+
 struct fman *fman_bind(struct device *dev);
 
 #endif /* __FM_H */