diff mbox series

xfrm: interface: do not confirm neighbor when do pmtu update

Message ID 1578906036-20623-1-git-send-email-vulab@iscas.ac.cn
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series xfrm: interface: do not confirm neighbor when do pmtu update | expand

Commit Message

Xu Wang Jan. 13, 2020, 9 a.m. UTC
When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 net/xfrm/xfrm_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steffen Klassert Jan. 15, 2020, 9:57 a.m. UTC | #1
On Mon, Jan 13, 2020 at 09:00:36AM +0000, Xu Wang wrote:
> When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
> we should not call dst_confirm_neigh() as there is no two-way communication.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Patch applied to the ipsec tree, thanks a lot!
diff mbox series

Patch

diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 7ac1542..e732637 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -297,7 +297,7 @@  xfrmi_xmit2(struct sk_buff *skb, struct net_device *dev, struct flowi *fl)
 
 	mtu = dst_mtu(dst);
 	if (!skb->ignore_df && skb->len > mtu) {
-		skb_dst_update_pmtu(skb, mtu);
+		skb_dst_update_pmtu_no_confirm(skb, mtu);
 
 		if (skb->protocol == htons(ETH_P_IPV6)) {
 			if (mtu < IPV6_MIN_MTU)