| Message ID | 1572521819-10458-11-git-send-email-madalin.bucur@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | DPAA Ethernet changes | expand |
On Thu, 2019-10-31 at 13:36 +0200, Madalin Bucur wrote: > User reports that an application making an (incorrect) call to > restart AN on a fixed link DPAA interface triggers an error in > the kernel log while the returned EINVAL should be enough. [] > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c [] > @@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device *net_dev, > struct ethtool_link_ksettings *cmd) > { > if (!net_dev->phydev) { > - netdev_dbg(net_dev, "phy device not initialized\n"); > return 0; > } ideally the now excess braces would be removed too. > @@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev, > int err; > > if (!net_dev->phydev) { > - netdev_err(net_dev, "phy device not initialized\n"); > return -ENODEV; > } etc...
> -----Original Message----- > From: Joe Perches <joe@perches.com> > Sent: Thursday, October 31, 2019 1:48 PM > To: Madalin Bucur <madalin.bucur@nxp.com>; davem@davemloft.net; > netdev@vger.kernel.org > Cc: Roy Pledge <roy.pledge@nxp.com>; jakub.kicinski@netronome.com > Subject: Re: [net-next 10/13] dpaa_eth: remove netdev_err() for user > errors > > On Thu, 2019-10-31 at 13:36 +0200, Madalin Bucur wrote: > > User reports that an application making an (incorrect) call to > > restart AN on a fixed link DPAA interface triggers an error in > > the kernel log while the returned EINVAL should be enough. > [] > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c > [] > > @@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device > *net_dev, > > struct ethtool_link_ksettings *cmd) > > { > > if (!net_dev->phydev) { > > - netdev_dbg(net_dev, "phy device not initialized\n"); > > return 0; > > } > > ideally the now excess braces would be removed too. You're right, I'll send a v2 > > @@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device > *net_dev, > > int err; > > > > if (!net_dev->phydev) { > > - netdev_err(net_dev, "phy device not initialized\n"); > > return -ENODEV; > > } > > etc... >
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index 1c689e11c61f..126c0f1d8442 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device *net_dev, struct ethtool_link_ksettings *cmd) { if (!net_dev->phydev) { - netdev_dbg(net_dev, "phy device not initialized\n"); return 0; } @@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev, int err; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return -ENODEV; } @@ -143,7 +141,6 @@ static int dpaa_nway_reset(struct net_device *net_dev) int err; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return -ENODEV; } @@ -168,7 +165,6 @@ static void dpaa_get_pauseparam(struct net_device *net_dev, mac_dev = priv->mac_dev; if (!net_dev->phydev) { - netdev_err(net_dev, "phy device not initialized\n"); return; }
User reports that an application making an (incorrect) call to restart AN on a fixed link DPAA interface triggers an error in the kernel log while the returned EINVAL should be enough. Reported-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 4 ---- 1 file changed, 4 deletions(-)