| Message ID | 1570612107-13286-1-git-send-email-zhengbin13@huawei.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | [RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' | expand |
zhengbin <zhengbin13@huawei.com> writes: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: zhengbin <zhengbin13@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> There's no changelog, why did you resend? Document clearly the changes so that maintainers don't need to guess what has changed: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
On 2019/10/9 20:58, Kalle Valo wrote: > zhengbin <zhengbin13@huawei.com> writes: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: >> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable] >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: zhengbin <zhengbin13@huawei.com> >> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > There's no changelog, why did you resend? Document clearly the changes > so that maintainers don't need to guess what has changed: Failed to apply: fatal: corrupt patch at line 13 error: could not build fake ancestor Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err' Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err' The copy of the patch that failed is found in: .git/rebase-apply/patch So I resend this. > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing >
"zhengbin (A)" <zhengbin13@huawei.com> writes: > On 2019/10/9 20:58, Kalle Valo wrote: >> zhengbin <zhengbin13@huawei.com> writes: >> >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: >>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: >>> variable err set but not used [-Wunused-but-set-variable] >>> >>> Reported-by: Hulk Robot <hulkci@huawei.com> >>> Signed-off-by: zhengbin <zhengbin13@huawei.com> >>> Acked-by: Ping-Ke Shih <pkshih@realtek.com> >> There's no changelog, why did you resend? Document clearly the changes >> so that maintainers don't need to guess what has changed: > > Failed to apply: > > fatal: corrupt patch at line 13 > error: could not build fake ancestor > Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err' > Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err' > The copy of the patch that failed is found in: .git/rebase-apply/patch > > So I resend this. Ok, thanks. But next time include the changelog automatically and mark the patch as v2. And read the documentation: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 2019/10/9 21:05, Kalle Valo wrote: > "zhengbin (A)" <zhengbin13@huawei.com> writes: > >> On 2019/10/9 20:58, Kalle Valo wrote: >>> zhengbin <zhengbin13@huawei.com> writes: >>> >>>> Fixes gcc '-Wunused-but-set-variable' warning: >>>> >>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: >>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: >>>> variable err set but not used [-Wunused-but-set-variable] >>>> >>>> Reported-by: Hulk Robot <hulkci@huawei.com> >>>> Signed-off-by: zhengbin <zhengbin13@huawei.com> >>>> Acked-by: Ping-Ke Shih <pkshih@realtek.com> >>> There's no changelog, why did you resend? Document clearly the changes >>> so that maintainers don't need to guess what has changed: >> Failed to apply: >> >> fatal: corrupt patch at line 13 >> error: could not build fake ancestor >> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err' >> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err' >> The copy of the patch that failed is found in: .git/rebase-apply/patch >> >> So I resend this. > Ok, thanks. But next time include the changelog automatically and mark > the patch as v2. And read the documentation: Copy that, thank your for your patience > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >
zhengbin <zhengbin13@huawei.com> wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: zhengbin <zhengbin13@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers-next.git, thanks. 59f4567d228f rtlwifi: rtl8192ee: Remove set but not used variable 'err'
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c index 67305ce..0546242 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c @@ -108,7 +108,6 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw) struct rtlwifi_firmware_header *pfwheader; u8 *pfwdata; u32 fwsize; - int err; enum version_8192e version = rtlhal->version; if (!rtlhal->pfirmware) @@ -146,9 +145,7 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw) _rtl92ee_write_fw(hw, version, pfwdata, fwsize); _rtl92ee_enable_fw_download(hw, false); - err = _rtl92ee_fw_free_to_go(hw); - - return 0; + return _rtl92ee_fw_free_to_go(hw); } static bool _rtl92ee_check_fw_read_last_h2c(struct ieee80211_hw *hw, u8 boxnum)