diff mbox series

net: dsa: sja1105: Make function sja1105_xfer_long_buf static

Message ID 1570183050-136729-1-git-send-email-zhengbin13@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series net: dsa: sja1105: Make function sja1105_xfer_long_buf static | expand

Commit Message

Zheng Bin Oct. 4, 2019, 9:57 a.m. UTC
Fix sparse warnings:

drivers/net/dsa/sja1105/sja1105_spi.c:159:5: warning: symbol 'sja1105_xfer_long_buf' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/net/dsa/sja1105/sja1105_spi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
2.7.4

Comments

David Miller Oct. 5, 2019, 12:25 a.m. UTC | #1
From: zhengbin <zhengbin13@huawei.com>
Date: Fri, 4 Oct 2019 17:57:30 +0800

> Fix sparse warnings:
> 
> drivers/net/dsa/sja1105/sja1105_spi.c:159:5: warning: symbol 'sja1105_xfer_long_buf' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/dsa/sja1105/sja1105_spi.c b/drivers/net/dsa/sja1105/sja1105_spi.c
index 4688467..b224b1a 100644
--- a/drivers/net/dsa/sja1105/sja1105_spi.c
+++ b/drivers/net/dsa/sja1105/sja1105_spi.c
@@ -156,9 +156,9 @@  int sja1105_xfer_u32(const struct sja1105_private *priv,
  * must be sent/received. Splitting the buffer into chunks and assembling
  * those into SPI messages is done automatically by this function.
  */
-int sja1105_xfer_long_buf(const struct sja1105_private *priv,
-			  sja1105_spi_rw_mode_t rw, u64 base_addr,
-			  void *packed_buf, u64 buf_len)
+static int sja1105_xfer_long_buf(const struct sja1105_private *priv,
+				 sja1105_spi_rw_mode_t rw, u64 base_addr,
+				 void *packed_buf, u64 buf_len)
 {
 	struct chunk {
 		void *buf_ptr;