| Message ID | 1565705150-17242-1-git-send-email-zhengbin13@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | sctp: fix memleak in sctp_send_reset_streams | expand |
On Tue, Aug 13, 2019 at 10:05:50PM +0800, zhengbin wrote: > If the stream outq is not empty, need to kfree nstr_list. > > Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: zhengbin <zhengbin13@huawei.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > --- > net/sctp/stream.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/stream.c b/net/sctp/stream.c > index 2594660..e83cdaa 100644 > --- a/net/sctp/stream.c > +++ b/net/sctp/stream.c > @@ -316,6 +316,7 @@ int sctp_send_reset_streams(struct sctp_association *asoc, > nstr_list[i] = htons(str_list[i]); > > if (out && !sctp_stream_outq_is_empty(stream, str_nums, nstr_list)) { > + kfree(nstr_list); > retval = -EAGAIN; > goto out; > } > -- > 2.7.4 >
On Tue, Aug 13, 2019 at 10:05:50PM +0800, zhengbin wrote: > If the stream outq is not empty, need to kfree nstr_list. > > Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: zhengbin <zhengbin13@huawei.com> > --- > net/sctp/stream.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/stream.c b/net/sctp/stream.c > index 2594660..e83cdaa 100644 > --- a/net/sctp/stream.c > +++ b/net/sctp/stream.c > @@ -316,6 +316,7 @@ int sctp_send_reset_streams(struct sctp_association *asoc, > nstr_list[i] = htons(str_list[i]); > > if (out && !sctp_stream_outq_is_empty(stream, str_nums, nstr_list)) { > + kfree(nstr_list); > retval = -EAGAIN; > goto out; > } > -- > 2.7.4 > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
On Tue, 13 Aug 2019 22:05:50 +0800, zhengbin wrote: > If the stream outq is not empty, need to kfree nstr_list. > > Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: zhengbin <zhengbin13@huawei.com> Applied, thank you!
diff --git a/net/sctp/stream.c b/net/sctp/stream.c index 2594660..e83cdaa 100644 --- a/net/sctp/stream.c +++ b/net/sctp/stream.c @@ -316,6 +316,7 @@ int sctp_send_reset_streams(struct sctp_association *asoc, nstr_list[i] = htons(str_list[i]); if (out && !sctp_stream_outq_is_empty(stream, str_nums, nstr_list)) { + kfree(nstr_list); retval = -EAGAIN; goto out; }
If the stream outq is not empty, need to kfree nstr_list. Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: zhengbin <zhengbin13@huawei.com> --- net/sctp/stream.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4