From patchwork Tue Feb 26 12:27:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 1048869 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MuzdFafk"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 448b5f4mytz9s4Y for ; Wed, 27 Feb 2019 23:46:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730172AbfB0MqN (ORCPT ); Wed, 27 Feb 2019 07:46:13 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35067 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbfB0MqN (ORCPT ); Wed, 27 Feb 2019 07:46:13 -0500 Received: by mail-pg1-f193.google.com with SMTP id e17so5877796pgd.2 for ; Wed, 27 Feb 2019 04:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Au5vlW0/T/UVsvKsDSVoNHoCDSTmkuAehtL6M83B73A=; b=MuzdFafkMeJ2bXNwfjJCy3CE1utmb1aEZ0QdqHCYgk0cZSyB9xscKRgusL1FRe8Eea vu5pitdpxYjWcNAW6CHhItE+DJRk7XS1Y5SYsA4mLM6ksWK64/ynRfhCc14vemrD76fH jc7IqxpvHpzR04HSOtJBmd5qJCDLttayNMY7Q8mIF8J3ymN3xt62w5LfgDexEOizjFk9 pcD68GDDSMrw/2sTKOvD/2pRPxuFfECWycmBQ4mM+hPV9b4aWtUO0IBXI/GKpP2LUA6Z 7eTZ5DlIAuGqHPKKfCBDhqdVl9oeN3G916lAElALdbtBjRZgCNGWlY7Bm8Nn527LggXN khkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Au5vlW0/T/UVsvKsDSVoNHoCDSTmkuAehtL6M83B73A=; b=HoVi/KlYi2DJpbKDXGyc+tN4MgF1HUiefe+zZJw+szM+Fc5RLuSo6fQ+ntQ6h0DvrK vGPXZ4eIKU8dr1jRKamBKPbRagtOcfOIgOQlEBa86jplshIcUEZLnAr1sCgvd3h7Ggjq IVLUE35BFdgQmPyRfnfy0JByC5q4yC7T1MZ+fE7w7jZ43nInIF0CrV/2pRiYuOQeOWAo BBCs8fowYCVwm76IG21Be8ct2iP4doFm0m/ojBWdqA5Z9sb6R+agxkhzFu0vH8N2X74N /f9Mh0vyAnTquVR4KlP9VEFLi7KUXToJMggk8DiNF83drTF6FzVWbeMkHNsGp8R61Mju 0nMw== X-Gm-Message-State: AHQUAub3Kkvn9ZiPGermAk+gw0nFxRrkht8xBGw9CHkxu26rSTczNdwr vDG7OT0D0fY7F1fAaqAGPLt2EHeV X-Google-Smtp-Source: AHgI3Iaq3aiH9stqtaCIxOgGOVrinKOG0WkyfpRuZvEcmphC+rGkWm/K5S7I9/NgQGmDcl8dNfwkxA== X-Received: by 2002:a62:ea10:: with SMTP id t16mr1449506pfh.3.1551271572046; Wed, 27 Feb 2019 04:46:12 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id q18sm18871238pgv.9.2019.02.27.04.46.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 04:46:11 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com, roid@mellanox.com Cc: netdev@vger.kernel.org, Tonghao Zhang Subject: [PATCH net-next v3 1/4] net/mlx5e: Make the log friendly when decapsulation offload not supported Date: Tue, 26 Feb 2019 04:27:40 -0800 Message-Id: <1551184063-40628-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551184063-40628-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1551184063-40628-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang If we try to offload decapsulation actions to VFs hw, we get the log [1]. It's not friendly, because the kind of net device is null, and we don't know what '0' means. [1] "mlx5_core 0000:05:01.2 vf_0: decapsulation offload is not supported for net device (0)" Signed-off-by: Tonghao Zhang Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c index bdcc5e7..6cbfbfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c @@ -84,7 +84,7 @@ static const char *mlx5e_netdev_kind(struct net_device *dev) if (dev->rtnl_link_ops) return dev->rtnl_link_ops->kind; else - return ""; + return "unknown"; } static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv, @@ -620,8 +620,10 @@ int mlx5e_tc_tun_parse(struct net_device *filter_dev, headers_c, headers_v); } else { netdev_warn(priv->netdev, - "decapsulation offload is not supported for %s net device (%d)\n", - mlx5e_netdev_kind(filter_dev), tunnel_type); + "decapsulation offload is not supported for %s (kind: \"%s\")\n", + netdev_name(filter_dev), + mlx5e_netdev_kind(filter_dev)); + return -EOPNOTSUPP; } return err;