| Message ID | 1551091207-10366-4-git-send-email-xiangxia.m.yue@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/mlx5e: Make little improvement for mlx5e | expand |
On 25/02/2019 12:40, xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > This patch is a little improvement. Simplify the parse_tc_fdb_actions(). > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index 708f819..e6583b9 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -2475,13 +2475,13 @@ static int parse_tc_vlan_action(struct mlx5e_priv *priv, > > static int parse_tc_fdb_actions(struct mlx5e_priv *priv, > struct flow_action *flow_action, > - struct mlx5e_tc_flow_parse_attr *parse_attr, > struct mlx5e_tc_flow *flow, > struct netlink_ext_ack *extack) > { > struct pedit_headers_action hdrs[2] = {}; > struct mlx5_eswitch *esw = priv->mdev->priv.eswitch; > struct mlx5_esw_flow_attr *attr = flow->esw_attr; > + struct mlx5e_tc_flow_parse_attr *parse_attr = attr->parse_attr; > struct mlx5e_rep_priv *rpriv = priv->ppriv; > const struct ip_tunnel_info *info = NULL; > const struct flow_action_entry *act; > @@ -2796,7 +2796,7 @@ static bool is_peer_flow_needed(struct mlx5e_tc_flow *flow) > if (err) > goto err_free; > > - err = parse_tc_fdb_actions(priv, &rule->action, parse_attr, flow, extack); > + err = parse_tc_fdb_actions(priv, &rule->action, flow, extack); > if (err) > goto err_free; > > Reviewed-by: Roi Dayan <roid@mellanox.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 708f819..e6583b9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -2475,13 +2475,13 @@ static int parse_tc_vlan_action(struct mlx5e_priv *priv, static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct flow_action *flow_action, - struct mlx5e_tc_flow_parse_attr *parse_attr, struct mlx5e_tc_flow *flow, struct netlink_ext_ack *extack) { struct pedit_headers_action hdrs[2] = {}; struct mlx5_eswitch *esw = priv->mdev->priv.eswitch; struct mlx5_esw_flow_attr *attr = flow->esw_attr; + struct mlx5e_tc_flow_parse_attr *parse_attr = attr->parse_attr; struct mlx5e_rep_priv *rpriv = priv->ppriv; const struct ip_tunnel_info *info = NULL; const struct flow_action_entry *act; @@ -2796,7 +2796,7 @@ static bool is_peer_flow_needed(struct mlx5e_tc_flow *flow) if (err) goto err_free; - err = parse_tc_fdb_actions(priv, &rule->action, parse_attr, flow, extack); + err = parse_tc_fdb_actions(priv, &rule->action, flow, extack); if (err) goto err_free;