diff mbox series

[net-next] net/mlx5e: Fix code style issue in mlx driver

Message ID 1548793891-43939-1-git-send-email-xiangxia.m.yue@gmail.com
State Not Applicable
Delegated to: David Miller
Headers show
Series [net-next] net/mlx5e: Fix code style issue in mlx driver | expand

Commit Message

Tonghao Zhang Jan. 29, 2019, 8:31 p.m. UTC 
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Add the tab before '}' and keep the code style consistent.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Or Gerlitz Jan. 31, 2019, 8:49 p.m. UTC | #1 
On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> Add the tab before '}' and keep the code style consistent.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

LGTM

Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Or Gerlitz Jan. 31, 2019, 8:51 p.m. UTC | #2 
On Thu, Jan 31, 2019 at 10:49 PM Or Gerlitz <gerlitz.or@gmail.com> wrote:
>
> On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > Add the tab before '}' and keep the code style consistent.
> >
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> LGTM

> Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>

oops, for files starting with en_ prefix we use net/mlx5e: prefix for the patch
title (ethernet) and for the others net/mlx5: (core) -- please fix and
re-send, add my R.B
and also make sure to copy Dave Miller
Tonghao Zhang Feb. 1, 2019, 1:12 a.m. UTC | #3 
On Fri, Feb 1, 2019 at 4:51 AM Or Gerlitz <gerlitz.or@gmail.com> wrote:
>
> On Thu, Jan 31, 2019 at 10:49 PM Or Gerlitz <gerlitz.or@gmail.com> wrote:
> >
> > On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > >
> > > Add the tab before '}' and keep the code style consistent.
> > >
> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > LGTM
>
> > Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
>
> oops, for files starting with en_ prefix we use net/mlx5e: prefix for the patch
> title (ethernet) and for the others net/mlx5: (core) -- please fix and
OK, thanks for your tips
> re-send, add my R.B
> and also make sure to copy Dave Miller
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 79f122b..9c5aac1 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -618,7 +618,8 @@  static struct mlx5_flow_group *alloc_flow_group(struct mlx5_flow_steering *steer
 	if (ret) {
 		kmem_cache_free(steering->fgs_cache, fg);
 		return ERR_PTR(ret);
-}
+	}
+
 	ida_init(&fg->fte_allocator);
 	fg->mask.match_criteria_enable = match_criteria_enable;
 	memcpy(&fg->mask.match_criteria, match_criteria,