| Message ID | 1547736856-16539-3-git-send-email-fabrizio.castro@bp.renesas.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | Correct CAN clocks definition | expand |
On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > According to the latest information, clkp2 is available on RZ/G2. > Modify CAN0 and CAN1 nodes accordingly. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > According to the latest information, clkp2 is available on RZ/G2. > > Modify CAN0 and CAN1 nodes accordingly. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > Thanks, > > This looks fine to me but I will wait to see if there are other reviews > before applying. > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Thanks again, applied for v5.1.
On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > According to the latest information, clkp2 is available on RZ/G2. > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > Thanks, > > > > This looks fine to me but I will wait to see if there are other reviews > > before applying. > > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Thanks again, applied for v5.1. Sorry, I was a little hasty there. This patch depends on the presence of R8A774A1_CLK_CANFD which (rightly) is added in a different patch in this series which is to go upstream via a different tree. I have dropped this patch for now. I think there are two solution to this problem. 1. Provide a version of this patch which uses a numeric index instead of R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an RC release provide a patch to switch to using R8A774A1_CLK_CANFD. 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
Hello Simon, Thank you for your feedback! > From: Simon Horman <horms@verge.net.au> > Sent: 23 January 2019 11:38 > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > Thanks, > > > > > > This looks fine to me but I will wait to see if there are other reviews > > > before applying. > > > > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > Thanks again, applied for v5.1. > > Sorry, I was a little hasty there. > > This patch depends on the presence of R8A774A1_CLK_CANFD which > (rightly) is added in a different patch in this series which is to > go upstream via a different tree. > > I have dropped this patch for now. I think there are two solution to this > problem. > > 1. Provide a version of this patch which uses a numeric index instead of > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > Yeah, my personal preference is solution 2. Thanks, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Fabrizio, On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > From: Simon Horman <horms@verge.net.au> > > Sent: 23 January 2019 11:38 > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > Thanks again, applied for v5.1. > > > > Sorry, I was a little hasty there. > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > (rightly) is added in a different patch in this series which is to > > go upstream via a different tree. > > > > I have dropped this patch for now. I think there are two solution to this > > problem. > > > > 1. Provide a version of this patch which uses a numeric index instead of > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > Yeah, my personal preference is solution 2. Note that solution 2 will probably defer the DT patch to v5.2. Gr{oetje,eeting}s, Geert
Hello Geert, Thank you for your feedback! > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 23 January 2019 12:08 > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > Hi Fabrizio, > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > From: Simon Horman <horms@verge.net.au> > > > Sent: 23 January 2019 11:38 > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > Thanks again, applied for v5.1. > > > > > > Sorry, I was a little hasty there. > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > (rightly) is added in a different patch in this series which is to > > > go upstream via a different tree. > > > > > > I have dropped this patch for now. I think there are two solution to this > > > problem. > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > Yeah, my personal preference is solution 2. > > Note that solution 2 will probably defer the DT patch to v5.2. Yeah, my understanding is that even if we chose solution 1 we would still need to be waiting for v5.2 for the patch to switch to using R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is fine. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > Hello Geert, > > Thank you for your feedback! > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > Sent: 23 January 2019 12:08 > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > Hi Fabrizio, > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > <fabrizio.castro@bp.renesas.com> wrote: > > > > From: Simon Horman <horms@verge.net.au> > > > > Sent: 23 January 2019 11:38 > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > Thanks again, applied for v5.1. > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > (rightly) is added in a different patch in this series which is to > > > > go upstream via a different tree. > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > problem. > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > Yeah, my personal preference is solution 2. > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > Yeah, my understanding is that even if we chose solution 1 we would still > need to be waiting for v5.2 for the patch to switch to using > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > fine. Your understanding is the same as mine. I do seem some slight value in option 1 in terms of getting the change, less the minor issue of using an index rather than a symbol, upstream earlier. But I do not feel strongly about this. I am marking this patch as deferred. Please repost or otherwise ping me when you would like to revisit this topic.
Hello Simon, Thank you for your feedback! > From: Simon Horman <horms@verge.net.au> > Sent: 24 January 2019 10:01 > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > > Hello Geert, > > > > Thank you for your feedback! > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > Sent: 23 January 2019 12:08 > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > Hi Fabrizio, > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > > From: Simon Horman <horms@verge.net.au> > > > > > Sent: 23 January 2019 11:38 > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > > > Thanks again, applied for v5.1. > > > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > > (rightly) is added in a different patch in this series which is to > > > > > go upstream via a different tree. > > > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > > problem. > > > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > > > Yeah, my personal preference is solution 2. > > > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > > > Yeah, my understanding is that even if we chose solution 1 we would still > > need to be waiting for v5.2 for the patch to switch to using > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > > fine. > > Your understanding is the same as mine. > > I do seem some slight value in option 1 in terms of getting the change, > less the minor issue of using an index rather than a symbol, upstream > earlier. But I do not feel strongly about this. > > I am marking this patch as deferred. Please repost or otherwise ping me > when you would like to revisit this topic. Thank you. Will do. Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback! > > > From: Simon Horman <horms@verge.net.au> > > Sent: 24 January 2019 10:01 > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > > > Hello Geert, > > > > > > Thank you for your feedback! > > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > > Sent: 23 January 2019 12:08 > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > Hi Fabrizio, > > > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > > > From: Simon Horman <horms@verge.net.au> > > > > > > Sent: 23 January 2019 11:38 > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > > > > > Thanks again, applied for v5.1. > > > > > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > > > (rightly) is added in a different patch in this series which is to > > > > > > go upstream via a different tree. > > > > > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > > > problem. > > > > > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > > > > > Yeah, my personal preference is solution 2. > > > > > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > > > > > Yeah, my understanding is that even if we chose solution 1 we would still > > > need to be waiting for v5.2 for the patch to switch to using > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > > > fine. > > > > Your understanding is the same as mine. > > > > I do seem some slight value in option 1 in terms of getting the change, > > less the minor issue of using an index rather than a symbol, upstream > > earlier. But I do not feel strongly about this. > > > > I am marking this patch as deferred. Please repost or otherwise ping me > > when you would like to revisit this topic. > > Thank you. Will do. Thanks. I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes" falls into the same category. I have marked it as deferred accordingly.
> From: Simon Horman <horms@verge.net.au> > Sent: 28 January 2019 13:01 > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote: > > Hello Simon, > > > > Thank you for your feedback! > > > > > From: Simon Horman <horms@verge.net.au> > > > Sent: 24 January 2019 10:01 > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > > > > Hello Geert, > > > > > > > > Thank you for your feedback! > > > > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > > > Sent: 23 January 2019 12:08 > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > Hi Fabrizio, > > > > > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > From: Simon Horman <horms@verge.net.au> > > > > > > > Sent: 23 January 2019 11:38 > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > > > > > > > Thanks again, applied for v5.1. > > > > > > > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > > > > (rightly) is added in a different patch in this series which is to > > > > > > > go upstream via a different tree. > > > > > > > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > > > > problem. > > > > > > > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > > > > > > > Yeah, my personal preference is solution 2. > > > > > > > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > > > > > > > Yeah, my understanding is that even if we chose solution 1 we would still > > > > need to be waiting for v5.2 for the patch to switch to using > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > > > > fine. > > > > > > Your understanding is the same as mine. > > > > > > I do seem some slight value in option 1 in terms of getting the change, > > > less the minor issue of using an index rather than a symbol, upstream > > > earlier. But I do not feel strongly about this. > > > > > > I am marking this patch as deferred. Please repost or otherwise ping me > > > when you would like to revisit this topic. > > > > Thank you. Will do. > > Thanks. > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes" > falls into the same category. I have marked it as deferred accordingly. Ok, thank you Simon Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Simon, > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro > Sent: 28 January 2019 14:49 > Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > From: Simon Horman <horms@verge.net.au> > > Sent: 28 January 2019 13:01 > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote: > > > Hello Simon, > > > > > > Thank you for your feedback! > > > > > > > From: Simon Horman <horms@verge.net.au> > > > > Sent: 24 January 2019 10:01 > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > > > > > Hello Geert, > > > > > > > > > > Thank you for your feedback! > > > > > > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > > > > Sent: 23 January 2019 12:08 > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > Hi Fabrizio, > > > > > > > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > > > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > > From: Simon Horman <horms@verge.net.au> > > > > > > > > Sent: 23 January 2019 11:38 > > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > > > > > > > > > Thanks again, applied for v5.1. > > > > > > > > > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > > > > > (rightly) is added in a different patch in this series which is to > > > > > > > > go upstream via a different tree. > > > > > > > > > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > > > > > problem. > > > > > > > > > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > > > > > > > > > Yeah, my personal preference is solution 2. > > > > > > > > > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > > > > > > > > > Yeah, my understanding is that even if we chose solution 1 we would still > > > > > need to be waiting for v5.2 for the patch to switch to using > > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > > > > > fine. > > > > > > > > Your understanding is the same as mine. > > > > > > > > I do seem some slight value in option 1 in terms of getting the change, > > > > less the minor issue of using an index rather than a symbol, upstream > > > > earlier. But I do not feel strongly about this. > > > > > > > > I am marking this patch as deferred. Please repost or otherwise ping me > > > > when you would like to revisit this topic. > > > > > > Thank you. Will do. > > > > Thanks. > > > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes" > > falls into the same category. I have marked it as deferred accordingly. > > Ok, thank you Simon My understanding is that this patch can now be taken, and it still applies neatly. Thanks, Fab > > Fab > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & > Wales under Registered No. 04586709.
On Tue, Mar 19, 2019 at 11:22:35AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro > > Sent: 28 January 2019 14:49 > > Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > From: Simon Horman <horms@verge.net.au> > > > Sent: 28 January 2019 13:01 > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote: > > > > Hello Simon, > > > > > > > > Thank you for your feedback! > > > > > > > > > From: Simon Horman <horms@verge.net.au> > > > > > Sent: 24 January 2019 10:01 > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote: > > > > > > Hello Geert, > > > > > > > > > > > > Thank you for your feedback! > > > > > > > > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > > > > > Sent: 23 January 2019 12:08 > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > > > Hi Fabrizio, > > > > > > > > > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro > > > > > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > > > From: Simon Horman <horms@verge.net.au> > > > > > > > > > Sent: 23 January 2019 11:38 > > > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes > > > > > > > > > > > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote: > > > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote: > > > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote: > > > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2. > > > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > > > > > > > > > > > > Thanks again, applied for v5.1. > > > > > > > > > > > > > > > > > > Sorry, I was a little hasty there. > > > > > > > > > > > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which > > > > > > > > > (rightly) is added in a different patch in this series which is to > > > > > > > > > go upstream via a different tree. > > > > > > > > > > > > > > > > > > I have dropped this patch for now. I think there are two solution to this > > > > > > > > > problem. > > > > > > > > > > > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of > > > > > > > > > R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an > > > > > > > > > RC release provide a patch to switch to using R8A774A1_CLK_CANFD. > > > > > > > > > > > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release. > > > > > > > > > > > > > > > > Yeah, my personal preference is solution 2. > > > > > > > > > > > > > > Note that solution 2 will probably defer the DT patch to v5.2. > > > > > > > > > > > > Yeah, my understanding is that even if we chose solution 1 we would still > > > > > > need to be waiting for v5.2 for the patch to switch to using > > > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is > > > > > > fine. > > > > > > > > > > Your understanding is the same as mine. > > > > > > > > > > I do seem some slight value in option 1 in terms of getting the change, > > > > > less the minor issue of using an index rather than a symbol, upstream > > > > > earlier. But I do not feel strongly about this. > > > > > > > > > > I am marking this patch as deferred. Please repost or otherwise ping me > > > > > when you would like to revisit this topic. > > > > > > > > Thank you. Will do. > > > > > > Thanks. > > > > > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes" > > > falls into the same category. I have marked it as deferred accordingly. > > > > Ok, thank you Simon > > My understanding is that this patch can now be taken, and it still applies neatly. Thanks, I agree this should be ready now. I've applied it for v5.2.
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 46a8fd2..71066d4 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -879,8 +879,10 @@ "renesas,rcar-gen3-can"; reg = <0 0xe6c30000 0 0x1000>; interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 916>, <&can_clk>; - clock-names = "clkp1", "can_clk"; + clocks = <&cpg CPG_MOD 916>, + <&cpg CPG_CORE R8A774A1_CLK_CANFD>, + <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>; resets = <&cpg 916>; status = "disabled"; @@ -891,8 +893,10 @@ "renesas,rcar-gen3-can"; reg = <0 0xe6c38000 0 0x1000>; interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 915>, <&can_clk>; - clock-names = "clkp1", "can_clk"; + clocks = <&cpg CPG_MOD 915>, + <&cpg CPG_CORE R8A774A1_CLK_CANFD>, + <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>; resets = <&cpg 915>; status = "disabled";