diff mbox series

net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()

Message ID 1545812910-77777-1-git-send-email-peng.hao2@zte.com.cn
State Accepted, archived
Delegated to: David Miller
Headers show
Series net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe() | expand

Commit Message

Peng Hao Dec. 26, 2018, 8:28 a.m. UTC 
From: Wen Yang <wen.yang99@zte.com.cn>

This patch fixes potential double frees if register_hdlc_device() fails.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>
CC: Zhao Qiang <qiang.zhao@nxp.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
---
 drivers/net/wan/fsl_ucc_hdlc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Dec. 28, 2018, 12:28 a.m. UTC | #1 
From: Peng Hao <peng.hao2@zte.com.cn>
Date: Wed, 26 Dec 2018 16:28:30 +0800

> From: Wen Yang <wen.yang99@zte.com.cn>
> 
> This patch fixes potential double frees if register_hdlc_device() fails.
> 
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 7a42336..839fa77 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -1180,7 +1180,6 @@  static int ucc_hdlc_probe(struct platform_device *pdev)
 	if (register_hdlc_device(dev)) {
 		ret = -ENOBUFS;
 		pr_err("ucc_hdlc: unable to register hdlc device\n");
-		free_netdev(dev);
 		goto free_dev;
 	}